Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: chrome/browser/diagnostics/diagnostics_writer.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/diagnostics/diagnostics_test.h ('k') | chrome/browser/diagnostics/diagnostics_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/diagnostics/diagnostics_writer.h
diff --git a/chrome/browser/diagnostics/diagnostics_writer.h b/chrome/browser/diagnostics/diagnostics_writer.h
index ca1b65354feffde523fc4499ff4572840ef6de8a..6e908ec7af660a7e0715ec1698270759f0e5d8bf 100644
--- a/chrome/browser/diagnostics/diagnostics_writer.h
+++ b/chrome/browser/diagnostics/diagnostics_writer.h
@@ -24,7 +24,7 @@ class DiagnosticsWriter : public DiagnosticsModel::Observer {
};
explicit DiagnosticsWriter(FormatType format);
- virtual ~DiagnosticsWriter();
+ ~DiagnosticsWriter() override;
// How many tests reported failure.
int failures() { return failures_; }
@@ -37,10 +37,10 @@ class DiagnosticsWriter : public DiagnosticsModel::Observer {
bool WriteInfoLine(const std::string& info_text);
// DiagnosticsModel::Observer overrides
- virtual void OnTestFinished(int index, DiagnosticsModel* model) override;
- virtual void OnAllTestsDone(DiagnosticsModel* model) override;
- virtual void OnRecoveryFinished(int index, DiagnosticsModel* model) override;
- virtual void OnAllRecoveryDone(DiagnosticsModel* model) override;
+ void OnTestFinished(int index, DiagnosticsModel* model) override;
+ void OnAllTestsDone(DiagnosticsModel* model) override;
+ void OnRecoveryFinished(int index, DiagnosticsModel* model) override;
+ void OnAllRecoveryDone(DiagnosticsModel* model) override;
private:
// Write a result block. For humans, it consists of two lines. The first line
« no previous file with comments | « chrome/browser/diagnostics/diagnostics_test.h ('k') | chrome/browser/diagnostics/diagnostics_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698