Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: chrome/browser/diagnostics/diagnostics_test.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/diagnostics/diagnostics_test.h
diff --git a/chrome/browser/diagnostics/diagnostics_test.h b/chrome/browser/diagnostics/diagnostics_test.h
index 3769f6decfbd0bacca0cb258825035548eb978ee..d2e51449fda9d97040a1b4b2ebeba8996cfae7ce 100644
--- a/chrome/browser/diagnostics/diagnostics_test.h
+++ b/chrome/browser/diagnostics/diagnostics_test.h
@@ -29,7 +29,7 @@ class DiagnosticsTest : public DiagnosticsModel::TestInfo {
public:
explicit DiagnosticsTest(DiagnosticsTestId id);
- virtual ~DiagnosticsTest();
+ ~DiagnosticsTest() override;
// Runs the test. Returning false signals that no more tests should be run.
// The actual outcome of the test should be set using the RecordXX functions.
@@ -62,14 +62,15 @@ class DiagnosticsTest : public DiagnosticsModel::TestInfo {
static base::FilePath GetUserDefaultProfileDir();
// DiagnosticsModel::TestInfo overrides
- virtual int GetId() const override;
- virtual std::string GetName() const override;
- virtual std::string GetTitle() const override;
- virtual DiagnosticsModel::TestResult GetResult() const override;
- virtual std::string GetAdditionalInfo() const override;
- virtual int GetOutcomeCode() const override;
- virtual base::Time GetStartTime() const override;
- virtual base::Time GetEndTime() const override;
+ int GetId() const override;
+ std::string GetName() const override;
+ std::string GetTitle() const override;
+ DiagnosticsModel::TestResult GetResult() const override;
+ std::string GetAdditionalInfo() const override;
+ int GetOutcomeCode() const override;
+ base::Time GetStartTime() const override;
+ base::Time GetEndTime() const override;
+
protected:
// Derived classes override this method do perform the actual test.
virtual bool ExecuteImpl(DiagnosticsModel::Observer* observer) = 0;
« no previous file with comments | « chrome/browser/diagnostics/diagnostics_model_unittest.cc ('k') | chrome/browser/diagnostics/diagnostics_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698