chrome/browser/content_settings/permission_queue_controller.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_queue_controller.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/permission_infobar_delegate.h ('k') | chrome/browser/content_settings/permission_queue_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_queue_controller.h

diff --git a/chrome/browser/content_settings/permission_queue_controller.h b/chrome/browser/content_settings/permission_queue_controller.h

index f953128b7eb0772234a9fc2709b5cdda56f8b978..ba2dbd424e0d3fff393c9d11ca2103b7f61eb50f 100644

--- a/chrome/browser/content_settings/permission_queue_controller.h

+++ b/chrome/browser/content_settings/permission_queue_controller.h

@@ -28,7 +28,7 @@ class PermissionQueueController : public content::NotificationObserver {

typedef base::Callback<void(bool /* allowed */)> PermissionDecidedCallback;

PermissionQueueController(Profile* profile, ContentSettingsType type);

- virtual ~PermissionQueueController();

+ ~PermissionQueueController() override;

// The InfoBar will be displayed immediately if the tab is not already

// displaying one, otherwise it'll be queued.

@@ -56,9 +56,9 @@ class PermissionQueueController : public content::NotificationObserver {

protected:

// content::NotificationObserver:

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

private:

class PendingInfobarRequest;