chrome/browser/content_settings/permission_infobar_delegate.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_infobar_delegate.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/permission_context_base_unittest.cc ('k') | chrome/browser/content_settings/permission_queue_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_infobar_delegate.h

diff --git a/chrome/browser/content_settings/permission_infobar_delegate.h b/chrome/browser/content_settings/permission_infobar_delegate.h

index 7df11913343e2eee4bf1563fc825f41e2e63a3cf..6897072522b8d77af162e6a2bf9e9c3a20e4b1c6 100644

--- a/chrome/browser/content_settings/permission_infobar_delegate.h

+++ b/chrome/browser/content_settings/permission_infobar_delegate.h

@@ -25,19 +25,19 @@ class PermissionInfobarDelegate : public ConfirmInfoBarDelegate {

const PermissionRequestID& id,

const GURL& requesting_origin,

ContentSettingsType type);

- virtual ~PermissionInfobarDelegate();

+ ~PermissionInfobarDelegate() override;

// ConfirmInfoBarDelegate:

virtual base::string16 GetMessageText() const = 0;

- virtual infobars::InfoBarDelegate::Type GetInfoBarType() const override;

- virtual base::string16 GetButtonLabel(InfoBarButton button) const override;

+ infobars::InfoBarDelegate::Type GetInfoBarType() const override;

+ base::string16 GetButtonLabel(InfoBarButton button) const override;

// Remember to call RegisterActionTaken for these methods if you are

// overriding them.

- virtual void InfoBarDismissed() override;

- virtual bool Accept() override;

- virtual bool Cancel() override;

+ void InfoBarDismissed() override;

+ bool Accept() override;

+ bool Cancel() override;

private:

void SetPermission(bool update_content_setting, bool allowed);