chrome/browser/content_settings/permission_context_base_unittest.cc - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_context_base_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/permission_context_base.h ('k') | chrome/browser/content_settings/permission_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_context_base_unittest.cc

diff --git a/chrome/browser/content_settings/permission_context_base_unittest.cc b/chrome/browser/content_settings/permission_context_base_unittest.cc

index 5d735740ad77fb56c478a6e5edb694e1dc294919..b5dddd2c2490c9e5f221492dc29913a85b78b8b8 100644

--- a/chrome/browser/content_settings/permission_context_base_unittest.cc

+++ b/chrome/browser/content_settings/permission_context_base_unittest.cc

@@ -42,7 +42,7 @@ class TestPermissionContext : public PermissionContextBase {

permission_granted_(false),

tab_context_updated_(false) {}

- virtual ~TestPermissionContext() {}

+ ~TestPermissionContext() override {}

PermissionQueueController* GetInfoBarController() {

return GetQueueController();

@@ -66,9 +66,9 @@ class TestPermissionContext : public PermissionContextBase {

}

protected:

- virtual void UpdateTabContext(const PermissionRequestID& id,

- const GURL& requesting_origin,

- bool allowed) override {

+ void UpdateTabContext(const PermissionRequestID& id,

+ const GURL& requesting_origin,

+ bool allowed) override {

tab_context_updated_ = true;

}