Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: chrome/browser/background/background_mode_manager.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_mode_manager.h
diff --git a/chrome/browser/background/background_mode_manager.h b/chrome/browser/background/background_mode_manager.h
index 1f2c4bacaa31ae6a07f0f73160f9a3f42ab35e90..2deef660fd1351be346852fc0d737b820c0425e0 100644
--- a/chrome/browser/background/background_mode_manager.h
+++ b/chrome/browser/background/background_mode_manager.h
@@ -56,7 +56,7 @@ class BackgroundModeManager
public:
BackgroundModeManager(base::CommandLine* command_line,
ProfileInfoCache* profile_cache);
- virtual ~BackgroundModeManager();
+ ~BackgroundModeManager() override;
static void RegisterPrefs(PrefRegistrySimple* registry);
@@ -119,13 +119,13 @@ class BackgroundModeManager
explicit BackgroundModeData(
Profile* profile,
CommandIdExtensionVector* command_id_extension_vector);
- virtual ~BackgroundModeData();
+ ~BackgroundModeData() override;
// The cached list of BackgroundApplications.
scoped_ptr<BackgroundApplicationListModel> applications_;
// Overrides from StatusIconMenuModel::Delegate implementation.
- virtual void ExecuteCommand(int command_id, int event_flags) override;
+ void ExecuteCommand(int command_id, int event_flags) override;
// Returns a browser window, or creates one if none are open. Used by
// operations (like displaying the preferences dialog) that require a
@@ -191,31 +191,29 @@ class BackgroundModeManager
typedef std::map<Profile*, BackgroundModeInfo> BackgroundModeInfoMap;
// content::NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// Called when the kBackgroundModeEnabled preference changes.
void OnBackgroundModeEnabledPrefChanged();
// BackgroundApplicationListModel::Observer implementation.
- virtual void OnApplicationDataChanged(const extensions::Extension* extension,
- Profile* profile) override;
- virtual void OnApplicationListChanged(Profile* profile) override;
+ void OnApplicationDataChanged(const extensions::Extension* extension,
+ Profile* profile) override;
+ void OnApplicationListChanged(Profile* profile) override;
// Overrides from ProfileInfoCacheObserver
- virtual void OnProfileAdded(const base::FilePath& profile_path) override;
- virtual void OnProfileWillBeRemoved(
- const base::FilePath& profile_path) override;
- virtual void OnProfileNameChanged(
- const base::FilePath& profile_path,
- const base::string16& old_profile_name) override;
+ void OnProfileAdded(const base::FilePath& profile_path) override;
+ void OnProfileWillBeRemoved(const base::FilePath& profile_path) override;
+ void OnProfileNameChanged(const base::FilePath& profile_path,
+ const base::string16& old_profile_name) override;
// Overrides from StatusIconMenuModel::Delegate implementation.
- virtual void ExecuteCommand(int command_id, int event_flags) override;
+ void ExecuteCommand(int command_id, int event_flags) override;
// chrome::BrowserListObserver implementation.
- virtual void OnBrowserAdded(Browser* browser) override;
+ void OnBrowserAdded(Browser* browser) override;
// Invoked when an extension is installed so we can ensure that
// launch-on-startup is enabled if appropriate. |extension| can be NULL when

Powered by Google App Engine
This is Rietveld 408576698