Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2568)

Unified Diff: chrome/browser/background/background_contents_service_unittest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_contents_service_unittest.cc
diff --git a/chrome/browser/background/background_contents_service_unittest.cc b/chrome/browser/background/background_contents_service_unittest.cc
index ca5953fb709d42ea0f41a22096273667752484f3..a42901cf28b57a3d4fa5477a2cf24d650119ab93 100644
--- a/chrome/browser/background/background_contents_service_unittest.cc
+++ b/chrome/browser/background/background_contents_service_unittest.cc
@@ -90,7 +90,7 @@ class MockBackgroundContents : public BackgroundContents {
content::Source<Profile>(profile_),
content::Details<BackgroundContents>(this));
}
- virtual const GURL& GetURL() const override { return url_; }
+ const GURL& GetURL() const override { return url_; }
void MockClose(Profile* profile) {
content::NotificationService::current()->Notify(
@@ -100,7 +100,7 @@ class MockBackgroundContents : public BackgroundContents {
delete this;
}
- virtual ~MockBackgroundContents() {
+ ~MockBackgroundContents() override {
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_BACKGROUND_CONTENTS_DELETED,
content::Source<Profile>(profile_),
@@ -125,7 +125,7 @@ class NotificationWaiter : public message_center::MessageCenterObserver {
public:
explicit NotificationWaiter(const std::string& target_id, Profile* profile)
: target_id_(target_id), profile_(profile) {}
- virtual ~NotificationWaiter() {}
+ ~NotificationWaiter() override {}
void WaitForNotificationAdded() {
DCHECK(!run_loop_.running());
@@ -139,14 +139,12 @@ class NotificationWaiter : public message_center::MessageCenterObserver {
private:
// message_center::MessageCenterObserver overrides:
- virtual void OnNotificationAdded(
- const std::string& notification_id) override {
+ void OnNotificationAdded(const std::string& notification_id) override {
if (notification_id == FindNotificationIdFromDelegateId(target_id_))
run_loop_.Quit();
}
- virtual void OnNotificationUpdated(
- const std::string& notification_id) override {
+ void OnNotificationUpdated(const std::string& notification_id) override {
if (notification_id == FindNotificationIdFromDelegateId(target_id_))
run_loop_.Quit();
}
« no previous file with comments | « chrome/browser/background/background_contents_service_factory.h ('k') | chrome/browser/background/background_mode_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698