Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4582)

Unified Diff: chrome/browser/autofill/autofill_server_browsertest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_server_browsertest.cc
diff --git a/chrome/browser/autofill/autofill_server_browsertest.cc b/chrome/browser/autofill/autofill_server_browsertest.cc
index a7cd12f7032f532631bf5959d3142c9a789d7cdb..49c8bc973b59816c6c33875bc4e6e92bf9408b81 100644
--- a/chrome/browser/autofill/autofill_server_browsertest.cc
+++ b/chrome/browser/autofill/autofill_server_browsertest.cc
@@ -35,7 +35,7 @@ class WindowedPersonalDataManagerObserver : public PersonalDataManagerObserver {
message_loop_runner_(new content::MessageLoopRunner){
PersonalDataManagerFactory::GetForProfile(profile_)->AddObserver(this);
}
- virtual ~WindowedPersonalDataManagerObserver() {}
+ ~WindowedPersonalDataManagerObserver() override {}
// Waits for the PersonalDataManager's list of profiles to be updated.
void Wait() {
@@ -44,9 +44,7 @@ class WindowedPersonalDataManagerObserver : public PersonalDataManagerObserver {
}
// PersonalDataManagerObserver:
- virtual void OnPersonalDataChanged() override {
- message_loop_runner_->Quit();
- }
+ void OnPersonalDataChanged() override { message_loop_runner_->Quit(); }
private:
Profile* profile_;
@@ -70,7 +68,7 @@ class WindowedNetworkObserver : public net::TestURLFetcher::DelegateForTests {
}
// net::TestURLFetcher::DelegateForTests:
- virtual void OnRequestStart(int fetcher_id) override {
+ void OnRequestStart(int fetcher_id) override {
net::TestURLFetcher* fetcher = factory_->GetFetcherByID(fetcher_id);
if (fetcher->upload_data() == expected_upload_data_)
message_loop_runner_->Quit();
@@ -78,8 +76,8 @@ class WindowedNetworkObserver : public net::TestURLFetcher::DelegateForTests {
// Not interested in any further status updates from this fetcher.
fetcher->SetDelegateForTests(NULL);
}
- virtual void OnChunkUpload(int fetcher_id) override {}
- virtual void OnRequestEnd(int fetcher_id) override {}
+ void OnChunkUpload(int fetcher_id) override {}
+ void OnRequestEnd(int fetcher_id) override {}
private:
// Mocks out network requests.
@@ -95,7 +93,7 @@ class WindowedNetworkObserver : public net::TestURLFetcher::DelegateForTests {
class AutofillServerTest : public InProcessBrowserTest {
public:
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
// Disable interactions with the Mac Keychain.
PrefService* pref_service = browser()->profile()->GetPrefs();
test::DisableSystemServices(pref_service);
« no previous file with comments | « chrome/browser/autofill/autofill_interactive_uitest.cc ('k') | chrome/browser/autofill/content_autofill_driver_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698