Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: chrome/browser/autofill/autofill_interactive_uitest.cc

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_interactive_uitest.cc
diff --git a/chrome/browser/autofill/autofill_interactive_uitest.cc b/chrome/browser/autofill/autofill_interactive_uitest.cc
index 806801b36684a197257e3fbce548666890014fff..eabd7dc5c3bba2b8964e30a1c5e6966fe8e3d3b9 100644
--- a/chrome/browser/autofill/autofill_interactive_uitest.cc
+++ b/chrome/browser/autofill/autofill_interactive_uitest.cc
@@ -99,20 +99,20 @@ class AutofillManagerTestDelegateImpl
: public autofill::AutofillManagerTestDelegate {
public:
AutofillManagerTestDelegateImpl() {}
- virtual ~AutofillManagerTestDelegateImpl() {}
+ ~AutofillManagerTestDelegateImpl() override {}
// autofill::AutofillManagerTestDelegate:
- virtual void DidPreviewFormData() override {
+ void DidPreviewFormData() override {
ASSERT_TRUE(loop_runner_->loop_running());
loop_runner_->Quit();
}
- virtual void DidFillFormData() override {
+ void DidFillFormData() override {
ASSERT_TRUE(loop_runner_->loop_running());
loop_runner_->Quit();
}
- virtual void DidShowSuggestions() override {
+ void DidShowSuggestions() override {
ASSERT_TRUE(loop_runner_->loop_running());
loop_runner_->Quit();
}
@@ -149,7 +149,7 @@ class WindowedPersonalDataManagerObserver
infobar_service_->AddObserver(this);
}
- virtual ~WindowedPersonalDataManagerObserver() {
+ ~WindowedPersonalDataManagerObserver() override {
while (infobar_service_->infobar_count() > 0) {
infobar_service_->RemoveInfoBar(infobar_service_->infobar_at(0));
}
@@ -157,7 +157,7 @@ class WindowedPersonalDataManagerObserver
}
// PersonalDataManagerObserver:
- virtual void OnPersonalDataChanged() override {
+ void OnPersonalDataChanged() override {
if (has_run_message_loop_) {
base::MessageLoopForUI::current()->Quit();
has_run_message_loop_ = false;
@@ -165,9 +165,7 @@ class WindowedPersonalDataManagerObserver
alerted_ = true;
}
- virtual void OnInsufficientFormData() override {
- OnPersonalDataChanged();
- }
+ void OnInsufficientFormData() override { OnPersonalDataChanged(); }
void Wait() {
@@ -181,7 +179,7 @@ class WindowedPersonalDataManagerObserver
private:
// infobars::InfoBarManager::Observer:
- virtual void OnInfoBarAdded(infobars::InfoBar* infobar) override {
+ void OnInfoBarAdded(infobars::InfoBar* infobar) override {
infobar_service_->infobar_at(0)->delegate()->AsConfirmInfoBarDelegate()->
Accept();
}
@@ -205,7 +203,7 @@ class AutofillInteractiveTest : public InProcessBrowserTest {
virtual ~AutofillInteractiveTest() {}
// InProcessBrowserTest:
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
// Don't want Keychain coming up on Mac.
test::DisableSystemServices(browser()->profile()->GetPrefs());
@@ -224,7 +222,7 @@ class AutofillInteractiveTest : public InProcessBrowserTest {
ASSERT_TRUE(ui_test_utils::SendMouseMoveSync(reset_mouse));
}
- virtual void TearDownOnMainThread() override {
+ void TearDownOnMainThread() override {
// Make sure to close any showing popups prior to tearing down the UI.
content::WebContents* web_contents = GetWebContents();
AutofillManager* autofill_manager = ContentAutofillDriver::FromWebContents(
« no previous file with comments | « chrome/browser/autofill/autofill_cc_infobar_delegate.h ('k') | chrome/browser/autofill/autofill_server_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698