Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: chrome/browser/favicon/favicon_service.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 12 matching lines...) Expand all
23 23
24 // The favicon service provides methods to access favicons. It calls the history 24 // The favicon service provides methods to access favicons. It calls the history
25 // backend behind the scenes. The callbacks are run asynchronously, even in the 25 // backend behind the scenes. The callbacks are run asynchronously, even in the
26 // case of an error. 26 // case of an error.
27 class FaviconService : public KeyedService { 27 class FaviconService : public KeyedService {
28 public: 28 public:
29 // TODO(jif): Remove usage of Profile. http://crbug.com/378208. 29 // TODO(jif): Remove usage of Profile. http://crbug.com/378208.
30 // The FaviconClient must outlive the constructed FaviconService. 30 // The FaviconClient must outlive the constructed FaviconService.
31 FaviconService(Profile* profile, FaviconClient* favicon_client); 31 FaviconService(Profile* profile, FaviconClient* favicon_client);
32 32
33 virtual ~FaviconService(); 33 ~FaviconService() override;
34 34
35 // We usually pass parameters with pointer to avoid copy. This function is a 35 // We usually pass parameters with pointer to avoid copy. This function is a
36 // helper to run FaviconResultsCallback with pointer parameters. 36 // helper to run FaviconResultsCallback with pointer parameters.
37 static void FaviconResultsCallbackRunner( 37 static void FaviconResultsCallbackRunner(
38 const favicon_base::FaviconResultsCallback& callback, 38 const favicon_base::FaviconResultsCallback& callback,
39 const std::vector<favicon_base::FaviconRawBitmapResult>* results); 39 const std::vector<favicon_base::FaviconRawBitmapResult>* results);
40 40
41 ////////////////////////////////////////////////////////////////////////////// 41 //////////////////////////////////////////////////////////////////////////////
42 // Methods to request favicon bitmaps from the history backend for |icon_url|. 42 // Methods to request favicon bitmaps from the history backend for |icon_url|.
43 // |icon_url| is the URL of the icon itself. 43 // |icon_url| is the URL of the icon itself.
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 void RunFaviconRawBitmapCallbackWithBitmapResults( 243 void RunFaviconRawBitmapCallbackWithBitmapResults(
244 const favicon_base::FaviconRawBitmapCallback& callback, 244 const favicon_base::FaviconRawBitmapCallback& callback,
245 int desired_size_in_pixel, 245 int desired_size_in_pixel,
246 const std::vector<favicon_base::FaviconRawBitmapResult>& 246 const std::vector<favicon_base::FaviconRawBitmapResult>&
247 favicon_bitmap_results); 247 favicon_bitmap_results);
248 248
249 DISALLOW_COPY_AND_ASSIGN(FaviconService); 249 DISALLOW_COPY_AND_ASSIGN(FaviconService);
250 }; 250 };
251 251
252 #endif // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_ 252 #endif // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | chrome/browser/favicon/favicon_service_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698