PushMessagingBrowserTest for registration success and failure

chrome/browser/services/gcm/push_messaging_constants.h

Index: chrome/browser/services/gcm/push_messaging_constants.h
diff --git a/chrome/browser/services/gcm/push_messaging_constants.h b/chrome/browser/services/gcm/push_messaging_constants.h
new file mode 100644
index 0000000000000000000000000000000000000000..3e0656a11df16c193e7ff53e8cb498864a6c463c
--- /dev/null
+++ b/chrome/browser/services/gcm/push_messaging_constants.h
@@ -0,0 +1,14 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_CONSTANTS_H_
+#define CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_CONSTANTS_H_
+
+namespace gcm {
+
+extern const char kPushMessagingEndpoint[];

[fgorski, 2014/10/20 22:29:08]

Why do you put this const into a separate file?

did you consider push_messaging_service.h or _impl.h?

[Michael van Ouwerkerk, 2014/10/21 10:32:01]

It seems cleaner. If you need the constant, you only need to pull in this file.
I don't feel strongly about it, except I'd rather avoid adding it to the public
content API, there's always a lot of pressure to avoid adding things to it.

[fgorski, 2014/10/21 17:16:53]

Acknowledged.

+
+}  // namespace gcm
+
+#endif  // CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_CONSTANTS_H_