chrome/browser/services/gcm/push_messaging_constants.h - Issue 648623003: PushMessagingBrowserTest for registration success and failure

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/services/gcm/push_messaging_constants.h

Issue 648623003: PushMessagingBrowserTest for registration success and failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Move profile setter. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/services/gcm/push_messaging_browsertest.cc ('K') | « chrome/browser/services/gcm/push_messaging_browsertest.cc ('k') | chrome/browser/services/gcm/push_messaging_constants.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_CONSTANTS_H_

	6 #define CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_CONSTANTS_H_

	7

	8 namespace gcm {

	9

	10 extern const char kPushMessagingEndpoint[];
	fgorski 2014/10/20 22:29:08 Why do you put this const into a separate file? d Why do you put this const into a separate file? did you consider push_messaging_service.h or _impl.h? Michael van Ouwerkerk 2014/10/21 10:32:01 It seems cleaner. If you need the constant, you on Show quoted text On 2014/10/20 22:29:08, fgorski wrote: > Why do you put this const into a separate file? > > did you consider push_messaging_service.h or _impl.h? It seems cleaner. If you need the constant, you only need to pull in this file. I don't feel strongly about it, except I'd rather avoid adding it to the public content API, there's always a lot of pressure to avoid adding things to it. fgorski 2014/10/21 17:16:53 Acknowledged. Show quoted text On 2014/10/21 10:32:01, Michael van Ouwerkerk wrote: > On 2014/10/20 22:29:08, fgorski wrote: > > Why do you put this const into a separate file? > > > > did you consider push_messaging_service.h or _impl.h? > > It seems cleaner. If you need the constant, you only need to pull in this file. > I don't feel strongly about it, except I'd rather avoid adding it to the public > content API, there's always a lot of pressure to avoid adding things to it. Acknowledged.
	11

	12 } // namespace gcm

	13

	14 #endif // CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_CONSTANTS_H_

OLD	NEW