Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 648243003: Revert of [Autofill Clean up] Revert changes introduced by Autocheckout to autofill (Closed)

Created:
6 years, 2 months ago by Evan Stade
Modified:
6 years, 2 months ago
Reviewers:
ziran.sun, Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Autofill Clean up] Revert changes introduced by Autocheckout to autofill (patchset #1 id:1 of https://codereview.chromium.org/609733003/) Reason for revert: these changes are still necessary for requestAutocomplete Original issue's description: > [Autofill Clean up] Revert changes introduced by Autocheckout to autofill > disabled and readonly fields. Autocheckout is deprecated. > > R=isherman@chromium.org > BUG=231160 > > Committed: https://crrev.com/d9b040ba4ff2ff78f183816b9d0e34c5f450160c > Cr-Commit-Position: refs/heads/master@{#297015} TBR=isherman@chromium.org,ziran.sun@samsung.com NOTREECHECKS=true NOTRY=true BUG=231160 Committed: https://crrev.com/33199a111975498bb568c605dd1173cc0bbe9db6 Cr-Commit-Position: refs/heads/master@{#299331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 6 chunks +34 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
Created Revert of [Autofill Clean up] Revert changes introduced by Autocheckout to autofill
6 years, 2 months ago (2014-10-13 18:35:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648243003/1
6 years, 2 months ago (2014-10-13 18:36:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 18:39:18 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 18:40:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33199a111975498bb568c605dd1173cc0bbe9db6
Cr-Commit-Position: refs/heads/master@{#299331}

Powered by Google App Engine
This is Rietveld 408576698