Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 648233002: Revert of Different fonts selected for width calculation and actual painting (Closed)

Created:
6 years, 2 months ago by cbiesinger
Modified:
6 years, 2 months ago
Reviewers:
tkent, behdad, h.joshi, eae
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, aandrey+blink_chromium.org, jchaffraix+rendering, pdr., Mikhail, blink-reviews-wtf_chromium.org, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@ellipsis_not_present
Project:
blink
Visibility:
Public.

Description

Revert of Different fonts selected for width calculation and actual painting (patchset #6 id:180001 of https://codereview.chromium.org/593673003/) Reason for revert: This broke fast/css/font-face-opentype.html and fast/text/line-break-after-question-mark.html on WinXP https://sheriff-o-matic.appspot.com/blink/failure/webkit_tests%3A%3Afast%2Fcss%2Ffont-face-opentype.html%3A%3Awebkit_tests%3A%3Afast%2Ftext%2Fline-break-after-question-mark.html Original issue's description: > In some cases different fonts are selected to get width of string and > to draw text. > In Font.cpp calls, font get changed due to fallback font architecture. > When making calls we need to check if Unicode is present in primary font or not. > In case of Ellipsis, we need to check if Ellipsis Unicode is present in primary font or not, > if not then use "Dot" Unicode, this is also suggested in CSS3 (http://www.w3.org/TR/2003/CR-css3-text-20030514/) > > BUG=416425 > TEST=fast/text/ellipsis-platform-font-change.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183597 TBR=eae@chromium.org,behdad@chromium.org,tkent@chromium.org,h.joshi@samsung.com NOTREECHECKS=true NOTRY=true BUG=416425 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183609

Patch Set 1 #

Patch Set 2 : make it apply #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -157 lines) Patch
M LayoutTests/TestExpectations View 1 2 chunks +4 lines, -1 line 0 comments Download
D LayoutTests/fast/text/ellipsis-platform-font-change.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
M LayoutTests/fast/text/line-break-after-question-mark-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/platform/linux/fast/text/ellipsis-platform-font-change-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/fast/text/ellipsis-platform-font-change-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/mac/fast/text/ellipsis-platform-font-change-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/text/ellipsis-platform-font-change-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/ellipsis-platform-font-change-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/ellipsis-platform-font-change-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/text/ellipsis-platform-font-change-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/text/ellipsis-platform-font-change-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win/fast/text/ellipsis-platform-font-change-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/fast/text/ellipsis-platform-font-change-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
A + LayoutTests/platform/win/fast/text/line-break-after-question-mark-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win/virtual/antialiasedtext/fast/text/ellipsis-platform-font-change-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/virtual/antialiasedtext/fast/text/ellipsis-platform-font-change-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/third_party/AndroidEmojiMonospace/AndroidEmoji.ttf.subset-uni203C.ttf View 1 Binary file 0 comments Download
D LayoutTests/third_party/AndroidEmojiMonospace/LICENSE.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/third_party/AndroidEmojiMonospace/README.chromium View 1 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 1 chunk +3 lines, -23 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 2 chunks +3 lines, -12 lines 0 comments Download
M Source/wtf/unicode/CharacterNames.h View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
cbiesinger
Created Revert of Different fonts selected for width calculation and actual painting
6 years, 2 months ago (2014-10-13 15:16:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648233002/1
6 years, 2 months ago (2014-10-13 15:16:53 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-13 15:17:03 UTC) #4
eae
LGTM
6 years, 2 months ago (2014-10-13 15:23:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648233002/260001
6 years, 2 months ago (2014-10-13 15:31:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:260001) as 183609
6 years, 2 months ago (2014-10-13 15:32:10 UTC) #8
h.joshi
6 years, 2 months ago (2014-10-13 15:38:50 UTC) #9
Message was sent while issue was closed.
Did not faced Windows bot issues for mentioned 
test cases. Will make new patch and check again.

Powered by Google App Engine
This is Rietveld 408576698