Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 648113002: Removing extensions::FeatureSwitch which is no longer used (Closed)

Created:
6 years, 2 months ago by krish
Modified:
5 years, 8 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing extensions::FeatureSwitch which is no longer used BUG=357228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -29 lines) Patch
M chrome/browser/extensions/extension_browsertest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 10 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_service.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
krish
PTAL
6 years, 2 months ago (2014-10-13 07:09:32 UTC) #2
Finnur
6 years, 2 months ago (2014-10-13 11:55:26 UTC) #3
I'm sorry, but this patch does not meet my quality standards.

In one case a bug has been introduced by hooking an else clause up to the wrong
if clause (extension_context_menu_model.cc) and it seems lines have in some
cases been deleted partially (extension_browsertest.h).

There are also numerous style issues. For example:
Indentation is never fixed when if tests are deleted nor empty lines removed
(after lines deleted).

I would also expect FeatureSwitch.h/.cc to be removed if the intent is to remove
the flags. Only then can we know if we've caught all lines that need to be
deleted.

But regardless of all this I question the timing of this patch because some of
those flags are under active development (e.g. extension_action_redesign) and
cannot be removed yet.

Powered by Google App Engine
This is Rietveld 408576698