Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 647973006: Remove a SkImageDecoder reference from SkPicture.h (Closed)

Created:
6 years, 2 months ago by Kimmo Kinnunen
Modified:
4 years, 10 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@separate-image-encoder-02-debug-functionality
Project:
skia
Visibility:
Public.

Description

Remove a SkImageDecoder reference from SkPicture.h Remove SkImageDecoder::DecodeMemory reference from the default proc parameter of SkPicture::CreateFromStream. Instead add an overload of CreateFromStream without the proc parameter. Make compilations with image library call the old function with the correct proc parameter. Make compilations without image library call the old function with NULL parameter. This is part of the work making it possible to compile core skia library without references to image decoders or encoders, e.g without the images library. This is needed in order to compile the images library to the standalone apps linking to the images-less Skia library. BUG=skia:2992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M dm/DMPipeTask.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPicture.h View 2 chunks +11 lines, -2 lines 0 comments Download
M include/core/SkWriteBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRecord.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrLayerHoister.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrPictureUtils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pdf/SkPDFDeviceFlattener.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkImagesSupport_default.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M src/ports/SkImagesSupport_noimages.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Kimmo Kinnunen
Depends on: https://codereview.chromium.org/665913002/
6 years, 2 months ago (2014-10-20 12:49:27 UTC) #2
scroggo
On 2014/10/20 12:49:27, Kimmo Kinnunen wrote: > Depends on: > https://codereview.chromium.org/665913002/ Currently, you can call ...
6 years, 2 months ago (2014-10-20 17:55:23 UTC) #3
Kimmo Kinnunen
On 2014/10/20 17:55:23, scroggo wrote: > On 2014/10/20 12:49:27, Kimmo Kinnunen wrote: > > Depends ...
6 years, 2 months ago (2014-10-20 18:27:30 UTC) #4
scroggo
4 years, 10 months ago (2016-02-12 19:01:35 UTC) #5
On 2014/10/20 18:27:30, Kimmo Kinnunen wrote:
> On 2014/10/20 17:55:23, scroggo wrote:
> > On 2014/10/20 12:49:27, Kimmo Kinnunen wrote:
> > > Depends on:
> > > https://codereview.chromium.org/665913002/
> > 
> > Currently, you can call SkPicture::CreateFromStream without building the
> images
> > sublibrary by building SkImageDecoder_empty.cpp. How is this approach
> > better/meaningfully different?
> 
> SkImageDecoder_empty.cpp is an implementation of SkImageDecoder.
> Can't have Skia have one implementation and the app have another
implementation,
> symbols clash.

Alternate solution in crrev.com/1671193002

Powered by Google App Engine
This is Rietveld 408576698