content/browser/service_worker/service_worker_register_job.cc - Issue 647953003: Service Worker script sizes in database.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 647953003: Service Worker script sizes in database. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Fixed crash where writer_ was null Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index 7921ee437b0a06d4e5cc66b99791ec48dcc15c54..7d7a0bff96aea22de3ce92d0c1a51870482eca60 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -493,9 +493,9 @@ void ServiceWorkerRegisterJob::OnPausedAfterDownload() {

registration()->active_version();

DCHECK(most_recent_version.get());

int64 most_recent_script_id =

- most_recent_version->script_cache_map()->Lookup(script_url_);

+ most_recent_version->script_cache_map()->LookupResourceId(script_url_);

int64 new_script_id =

- new_version()->script_cache_map()->Lookup(script_url_);

+ new_version()->script_cache_map()->LookupResourceId(script_url_);

// TODO(michaeln): It would be better to compare as the new resource

// is being downloaded and to avoid writing it to disk until we know