Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 647953003: Service Worker script sizes in database. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Fixed crash where writer_ was null Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc
index 85b14887460a096df7a36d934149ff2aba3a74ef..144cb90e69da4026e16849dbb845cc27860fd401 100644
--- a/content/browser/service_worker/service_worker_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_job_unittest.cc
@@ -933,6 +933,7 @@ class UpdateJobTestHelper
const GURL& script,
bool pause_after_download) override {
const std::string kMockScriptBody = "mock_script";
+ const uint64 kMockScriptSize = 19284;
ServiceWorkerVersion* version = context()->GetLiveVersion(version_id);
ASSERT_TRUE(version);
version->AddListener(this);
@@ -943,7 +944,7 @@ class UpdateJobTestHelper
version->script_cache_map()->NotifyStartedCaching(script, resource_id);
WriteStringResponse(storage(), resource_id, kMockScriptBody);
version->script_cache_map()->NotifyFinishedCaching(
- script, net::URLRequestStatus());
+ script, kMockScriptSize, net::URLRequestStatus());
} else {
// Spoof caching the script for the new version.
int64 resource_id = storage()->NewResourceId();
@@ -953,7 +954,7 @@ class UpdateJobTestHelper
else
WriteStringResponse(storage(), resource_id, "mock_different_script");
version->script_cache_map()->NotifyFinishedCaching(
- script, net::URLRequestStatus());
+ script, kMockScriptSize, net::URLRequestStatus());
}
EmbeddedWorkerTestHelper::OnStartWorker(
embedded_worker_id, version_id, scope, script, pause_after_download);

Powered by Google App Engine
This is Rietveld 408576698