net/quic/test_tools/crypto_test_utils.cc - Issue 647933002: Call SetDefaults from the QuicConfig constructor instead of requiring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/crypto_test_utils.cc

Issue 647933002: Call SetDefaults from the QuicConfig constructor instead of requiring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Allow_number_of_undecryptable_packets_76707156

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/test_tools/crypto_test_utils.cc

diff --git a/net/quic/test_tools/crypto_test_utils.cc b/net/quic/test_tools/crypto_test_utils.cc

index fe7e8721ccf1b4d1f44e30ffb3398509132a7c65..9f4dc8bf73342942cc16736f8cdde9944fe66a91 100644

--- a/net/quic/test_tools/crypto_test_utils.cc

+++ b/net/quic/test_tools/crypto_test_utils.cc

@@ -219,8 +219,6 @@ int CryptoTestUtils::HandshakeWithFakeClient(

TestClientSession client_session(client_conn, DefaultQuicConfig());

QuicCryptoClientConfig crypto_config;

- client_session.config()->SetDefaults();

- crypto_config.SetDefaults();

if (!options.dont_verify_certs) {

// TODO(wtc): replace this with ProofVerifierForTesting() when we have

// a working ProofSourceForTesting().

@@ -273,7 +271,6 @@ void CryptoTestUtils::SetupCryptoServerConfigForTest(

QuicRandom* rand,

QuicConfig* config,

QuicCryptoServerConfig* crypto_config) {

- config->SetDefaults();

QuicCryptoServerConfig::ConfigOptions options;

options.channel_id_enabled = true;

scoped_ptr<CryptoHandshakeMessage> scfg(

« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | net/quic/test_tools/quic_test_utils.cc » ('j') | no next file with comments »