Remove RenderObject::checkForPaintInvalidation()

Remove RenderObject::checkForPaintInvalidation()

It was used during layout to avoid unnecessary local invalidations.
However, with RACUN we set flag instead of issuing invalidation during
layout, making the local invalidation optimization unnecessary.

Also the name is confusing with shouldCheckForPaintInvalidation().

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183679

[Julien - ping for review, 2014-10-13 21:26:54]

jchaffraix@chromium.org changed reviewers:
+ dsinclair@chromium.org, jchaffraix@chromium.org, leviw@chromium.org

[Julien - ping for review, 2014-10-13 21:26:54]

lgtm.

This change is correct as the layouts' before the first frame invalidations are
going to be disabled by the FrameView. New renderers being inserted into the
tree afterwards do require layout to generate invalidations so this check was
unneeded for them.

https://codereview.chromium.org/647903002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlockFlow.cpp (right):

https://codereview.chromium.org/647903002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlockFlow.cpp:672: // If the child moved, we have to
invalidate it's paint as well as any floating/positioned
s/it's/its/

[Xianzhu, 2014-10-13 21:35:37]

https://codereview.chromium.org/647903002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlockFlow.cpp (right):

https://codereview.chromium.org/647903002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlockFlow.cpp:672: // If the child moved, we have to
invalidate it's paint as well as any floating/positioned
On 2014/10/13 21:26:54, Julien Chaffraix - PST wrote:
> s/it's/its/

Done.

[Xianzhu, 2014-10-13 21:35:40]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-10-13 21:36:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/647903002/160001

[commit-bot: I haz the power, 2014-10-14 00:35:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 00:35:39]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31582)

[Xianzhu, 2014-10-14 15:54:45]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-10-14 15:55:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/647903002/160001

[commit-bot: I haz the power, 2014-10-14 16:44:35]

Committed patchset #2 (id:160001) as 183679