Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Side by Side Diff: Source/core/rendering/RenderTableRow.cpp

Issue 647903002: Remove RenderObject::checkForPaintInvalidation() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 cell->layout(); 178 cell->layout();
179 } 179 }
180 } 180 }
181 181
182 m_overflow.clear(); 182 m_overflow.clear();
183 addVisualEffectOverflow(); 183 addVisualEffectOverflow();
184 184
185 // We only ever need to issue paint invalidations if our cells didn't, which means that they didn't need 185 // We only ever need to issue paint invalidations if our cells didn't, which means that they didn't need
186 // layout, so we know that our bounds didn't change. This code is just makin g up for 186 // layout, so we know that our bounds didn't change. This code is just makin g up for
187 // the fact that we did not invalidate paints in setStyle() because we had a layout hint. 187 // the fact that we did not invalidate paints in setStyle() because we had a layout hint.
188 // We cannot call paintInvalidationForWholeRenderer() because our clippedOve rflowRectForPaintInvalidation() is taken from the 188 if (selfNeedsLayout()) {
189 // parent table, and being mid-layout, that is invalid. Instead, we issue pa int invalidations for our cells.
190 if (selfNeedsLayout() && checkForPaintInvalidation()) {
191 for (RenderTableCell* cell = firstCell(); cell; cell = cell->nextCell()) { 189 for (RenderTableCell* cell = firstCell(); cell; cell = cell->nextCell()) {
192 // FIXME: Is this needed when issuing paint invalidations after layo ut? 190 // FIXME: Is this needed when issuing paint invalidations after layo ut?
193 cell->setShouldDoFullPaintInvalidation(); 191 cell->setShouldDoFullPaintInvalidation();
194 } 192 }
195 } 193 }
196 194
197 // RenderTableSection::layoutRows will set our logical height and width late r, so it calls updateLayerTransform(). 195 // RenderTableSection::layoutRows will set our logical height and width late r, so it calls updateLayerTransform().
198 clearNeedsLayout(); 196 clearNeedsLayout();
199 } 197 }
200 198
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 238
241 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent) 239 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent)
242 { 240 {
243 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() ); 241 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() );
244 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW); 242 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW);
245 newRow->setStyle(newStyle.release()); 243 newRow->setStyle(newStyle.release());
246 return newRow; 244 return newRow;
247 } 245 }
248 246
249 } // namespace blink 247 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698