Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 647763004: Clean-up Chrome Apps codelab. (Closed)

Created:
6 years, 2 months ago by mkearney1
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean-up Chrome Apps codelab. Some of the updated files got accidentally stashed and I needed to pop and recheck that the content was up-to-date. Committed: https://crrev.com/fd1ee51ed8d15fbc90bd76d2a0e67d4dc664a3ae Cr-Commit-Position: refs/heads/master@{#300334}

Patch Set 1 #

Messages

Total messages: 8 (2 generated)
mkearney1
As promised, a second round of clean-ups to the Chrome apps codelab. Just needed to ...
6 years, 2 months ago (2014-10-20 20:03:39 UTC) #2
not at google - send to devlin
rslgtm
6 years, 2 months ago (2014-10-20 20:10:42 UTC) #3
not at google - send to devlin
apparently that doesn't trigger as a lgtm
6 years, 2 months ago (2014-10-20 20:10:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647763004/1
6 years, 2 months ago (2014-10-20 20:18:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 21:44:58 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 21:45:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd1ee51ed8d15fbc90bd76d2a0e67d4dc664a3ae
Cr-Commit-Position: refs/heads/master@{#300334}

Powered by Google App Engine
This is Rietveld 408576698