Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: chrome/common/extensions/docs/templates/articles/app_codelab_webview.html

Issue 647763004: Clean-up Chrome Apps codelab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/templates/articles/app_codelab_intro.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/templates/articles/app_codelab_webview.html
diff --git a/chrome/common/extensions/docs/templates/articles/app_codelab_webview.html b/chrome/common/extensions/docs/templates/articles/app_codelab_webview.html
index e4dcaac1445a43091bad341c3016cb347e2f2279..0fef7a116ac12caa7b064a7b7de1d252581348c8 100644
--- a/chrome/common/extensions/docs/templates/articles/app_codelab_webview.html
+++ b/chrome/common/extensions/docs/templates/articles/app_codelab_webview.html
@@ -32,14 +32,15 @@ a custom HTML tag called <a href="/apps/tags/webview">webview</a>.</p>
<img src="{{static}}/images/app_codelab/webview-example.png" alt="The Todo app using a webview">
</figure>
-<p class="note">A webview is a sandboxed process. For example, the enclosing Chrome App
-(also known as the "embedder page") cannot easily access the webview's loaded DOM.
+<p class="note"><strong>Webviews are sandboxed processes:</strong>
+The enclosing Chrome App (also known as the "embedder page")
+cannot easily access the webview's loaded DOM.
You can only interact with the webview using its API.</p>
<h2 id="implement-webview">Implement the webview tag</h2>
-<p>Let's update our Todo app to search for URLs in the todo item text
-in order to create a hyperlink. The link, when clicked, will open a new Chrome App window
+<p>Update the Todo app to search for URLs in the todo item text and create a hyperlink.
+The link, when clicked, opens a new Chrome App window
(not a browser tab) with a webview presenting the content.</p>
<h3 id="update-permissions">Update permissions</h3>
@@ -86,12 +87,12 @@ This file is a basic webpage with one <code>&lt;webview&gt;</code> tag:</p>
})(window);
</pre>
-<p>Whenever a string starting with "http://" or "https://" is found, a HTML anchor tag will be created to wrap around the URL.</p>
+<p>Whenever a string starting with "http://" or "https://" is found, a HTML anchor tag is created to wrap around the URL.</p>
<h3 id="render-links">Render hyperlinks in the todo list</h3>
<p>Find <code>showAll()</code> in <em>controller.js</em>. Update <code>showAll()</code>
-to parse for links by using the <code>_parseForURLs()</code> method that we added previously:</p>
+to parse for links by using the <code>_parseForURLs()</code> method added previously:</p>
<pre data-filename="controller.js">
/**
@@ -164,7 +165,7 @@ Controller.prototype.editItem = function (id, label) {
<h3 id="open-webview">Open new window containing webview</h3>
-<p>Add a <code>_doShowUrl()</code> method to <em>controller.js</em>. This method will open a new Chrome App window
+<p>Add a <code>_doShowUrl()</code> method to <em>controller.js</em>. This method opens a new Chrome App window
via <a href="/apps/app_window.html#method-create">chrome.app.window.create()</a>
with <em>webview.html</em> as the window source:</p>
@@ -233,7 +234,7 @@ starting with http:// or https://, you should see something like this:</p>
<img src="{{static}}/images/app_codelab/step4-completed.gif" alt="The Todo app with webview"/>
</figure>
-<h2 id="recap">Recap APIs referenced in this step</h2>
+<h2 id="recap">For more information</h2>
<p>For more detailed information about some of the APIs introduced in this step, refer to:</p>
@@ -245,16 +246,11 @@ starting with http:// or https://, you should see something like this:</p>
<li>
<a href="/apps/tags/webview" title="Read '&lt;webview&gt; Tag' in the Chrome developer docs">&lt;webview&gt; Tag</a>
<a href="#overview" class="anchor-link-icon" title="This feature mentioned in 'Learn about the webview tag'">&#8593;</a>
- <a href="#create-webview" class="anchor-link-icon" title="This feature mentioned in 'Create a webview embedder page'">&#8593;</a>
</li>
<li>
<a href="/apps/app_window.html#method-create" title="Read 'chrome.app.window.create()' in the Chrome developer docs">chrome.app.window.create()</a>
<a href="#open-webview" class="anchor-link-icon" title="This feature mentioned in 'Open new window containing webview'">&#8593;</a>
</li>
- <li>
- <a href="/apps/tags/webview#tag" title="Read '&lt;webview&gt; Tag attributes' in the Chrome developer docs">&lt;webview&gt; Tag attributes</a>
- <a href="#open-webview" class="anchor-link-icon" title="This feature mentioned in 'Open new window containing webview'">&#8593;</a>
- </li>
</ul>
« no previous file with comments | « chrome/common/extensions/docs/templates/articles/app_codelab_intro.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698