Issue 64763004: IDL compiler: [Unforgeable] methods

Issue 64763004: IDL compiler: [Unforgeable] methods (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)

Modified:
7 years, 1 month ago

Reviewers:
haraken

CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: [Unforgeable] methods Last extended attribute for methods! Also refactored two blocks (3-way conditionals) into functions, which feels simpler and more direct, and added renaming FIXME. BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161605

Patch Set 1 #

Patch Set 2 : FIXME #

Total comments: 2

Patch Set 3 : Rebased #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -9 lines)			Patch
M	Source/bindings/scripts/unstable/v8_methods.py	View	1 2	3 chunks	+22 lines, -9 lines	0 comments	Download
M	Source/bindings/tests/idls/TestObjectPython.idl	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObjectPython.cpp	View	1 2	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM > Last extended attribute for methods! Great! Probably you might want to spend time ...

7 years, 1 month ago (2013-11-08 07:44:11 UTC) #2

Nils Barth (inactive)

https://codereview.chromium.org/64763004/diff/30001/Source/bindings/scripts/unstable/v8_methods.py File Source/bindings/scripts/unstable/v8_methods.py (right): https://codereview.chromium.org/64763004/diff/30001/Source/bindings/scripts/unstable/v8_methods.py#newcode58 Source/bindings/scripts/unstable/v8_methods.py:58: # proto => prototypeTemplate On 2013/11/08 07:44:11, haraken wrote: ...

7 years, 1 month ago (2013-11-08 10:20:13 UTC) #3

Nils Barth (inactive)

On 2013/11/08 07:44:11, haraken wrote: > > Last extended attribute for methods! > > Great! ...

7 years, 1 month ago (2013-11-08 10:21:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/64763004/100001

7 years, 1 month ago (2013-11-08 10:24:46 UTC) #5

Message was sent while issue was closed.

Change committed as 161605

Expand Messages | Collapse Messages