IDL compiler: [Unforgeable] methods

Source/bindings/scripts/unstable/v8_methods.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 32 matching lines @@
 
 def generate_method(interface, method):
     arguments = method.arguments
     extended_attributes = method.extended_attributes
     idl_type = method.idl_type
     is_static = method.is_static
     name = method.name
 
     this_cpp_value = cpp_value(interface, method, len(arguments))
     this_custom_signature = custom_signature(arguments)
-    if this_custom_signature:
-        signature = name + 'Signature'
-    elif is_static or 'DoNotCheckSignature' in extended_attributes:
-        signature = 'v8::Local<v8::Signature>()'
-    else:
-        signature = 'defaultSignature'
+
+    def function_template():
+        # FIXME: Rename as follows:
+        # desc => functionTemplate
+        # instance => instanceTemplate
+        # proto => prototypeTemplate

[haraken, 2013/11/08 07:44:11]

Please do the same rename in V8DOMConfituration.

[Nils Barth (inactive), 2013/11/08 10:20:13]

Will do, updated FIXME.

+        if is_static:
+            return 'desc'
+        if 'Unforgeable' in extended_attributes:
+            return 'instance'
+        return 'proto'
+
+    def signature():
+        if this_custom_signature:
+            return name + 'Signature'
+        if is_static or 'DoNotCheckSignature' in extended_attributes:
+            return 'v8::Local<v8::Signature>()'
+        return 'defaultSignature'
 
     is_call_with_script_arguments = has_extended_attribute_value(method, 'CallWith', 'ScriptArguments')
     if is_call_with_script_arguments:
         includes.update(['bindings/v8/ScriptCallStackFactory.h',
                          'core/inspector/ScriptArguments.h'])
     is_call_with_script_state = has_extended_attribute_value(method, 'CallWith', 'ScriptState')
     if is_call_with_script_state:
         includes.add('bindings/v8/ScriptState.h')
     is_check_security_for_node = 'CheckSecurityForNode' in extended_attributes
     if is_check_security_for_node:
@@ skipping 10 matching lines @@
         'activity_logging_world_list': v8_utilities.activity_logging_world_list(method),  # [ActivityLogging]
         'arguments': [generate_argument(interface, method, argument, index)
                       for index, argument in enumerate(arguments)],
         'conditional_string': v8_utilities.conditional_string(method),
         'cpp_type': v8_types.cpp_type(idl_type),
         'cpp_value': this_cpp_value,
         'custom_signature': this_custom_signature,
         'deprecate_as': v8_utilities.deprecate_as(method),  # [DeprecateAs]
         'do_not_check_signature': not(this_custom_signature or is_static or
             v8_utilities.has_extended_attribute(method,
-                ['DoNotCheckSignature', 'NotEnumerable', 'ReadOnly'])),
-        'function_template': 'desc' if method.is_static else 'proto',
+                ['DoNotCheckSignature', 'NotEnumerable', 'ReadOnly',
+                 'Unforgeable'])),
+        'function_template': function_template(),
         'idl_type': idl_type,
         'is_call_with_execution_context': has_extended_attribute_value(method, 'CallWith', 'ExecutionContext'),
         'is_call_with_script_arguments': is_call_with_script_arguments,
         'is_call_with_script_state': is_call_with_script_state,
         'is_check_security_for_node': is_check_security_for_node,
         'is_custom': 'Custom' in extended_attributes,
         'is_custom_element_callbacks': is_custom_element_callbacks,
         'is_per_world_bindings': 'PerWorldBindings' in extended_attributes,
         'is_raises_exception': is_raises_exception,
         'is_static': is_static,
         'measure_as': v8_utilities.measure_as(method),  # [MeasureAs]
         'name': name,
         'number_of_arguments': len(arguments),
         'number_of_required_arguments': len([
             argument for argument in arguments
             if not (argument.is_optional or argument.is_variadic)]),
         'number_of_required_or_variadic_arguments': len([
             argument for argument in arguments
             if not argument.is_optional]),
         'per_context_enabled_function_name': v8_utilities.per_context_enabled_function_name(method),  # [PerContextEnabled]
         'property_attributes': property_attributes(method),
-        'signature': signature,
+        'signature': signature(),
         'v8_set_return_value': v8_set_return_value(method, this_cpp_value),
         'world_suffixes': ['', 'ForMainWorld'] if 'PerWorldBindings' in extended_attributes else [''],  # [PerWorldBindings]
     }
     return contents
 
 
 def generate_argument(interface, method, argument, index):
     extended_attributes = argument.extended_attributes
     idl_type = argument.idl_type
     this_cpp_value = cpp_value(interface, method, index)
@@ skipping 82 matching lines @@
         return 'V8TRYCATCH_VOID(Vector<{cpp_type}>, {name}, toNativeArguments<{cpp_type}>(info, {index}))'.format(
                 cpp_type=v8_types.cpp_type(idl_type), name=name, index=index)
     # [Default=NullString]
     if (argument.is_optional and idl_type == 'DOMString' and
         extended_attributes.get('Default') == 'NullString'):
         v8_value = 'argumentOrNull(info, %s)' % index
     else:
         v8_value = 'info[%s]' % index
     return v8_types.v8_value_to_local_cpp_value(
         idl_type, argument.extended_attributes, v8_value, name, index=index)