Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 647623003: Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute() (Closed)

Created:
6 years, 2 months ago by Hajime Morrita
Modified:
6 years, 2 months ago
Reviewers:
amineer, nasko, karen
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute() This is an equivalent of DCHECK() in IDMap. According to crbug.com/381990, this can occasionally crash. I'd like to enable this to collect more data if it still crashes. If you see this CHECK() being hit in the wild, please revert this change and let me know. BUG=381990, 415059 R=nasko@chromium.org, amineer@chromium.org Committed: https://crrev.com/9a8e3d71f73ace82874d53ba2e749b1173a98513 Cr-Commit-Position: refs/heads/master@{#299146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Hajime Morrita
6 years, 2 months ago (2014-10-10 01:23:31 UTC) #1
nasko
lgtm
6 years, 2 months ago (2014-10-10 02:45:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647623003/1
6 years, 2 months ago (2014-10-10 17:58:23 UTC) #4
amineer_google
On 2014/10/10 17:58:23, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 2 months ago (2014-10-10 18:11:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 18:30:10 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9a8e3d71f73ace82874d53ba2e749b1173a98513 Cr-Commit-Position: refs/heads/master@{#299146}
6 years, 2 months ago (2014-10-10 18:31:02 UTC) #8
kareng
6 years, 2 months ago (2014-10-11 19:30:17 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/645233003/ by kareng@google.com.

The reason for reverting is: per bug
https://code.google.com/p/chromium/issues/detail?id=422694 a bunch of crashes
both in mac and windows today's canary..

Powered by Google App Engine
This is Rietveld 408576698