Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 647623003: Add a crash-hunting CHECK() in RenderProcessHostImpl::AddRoute() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 978916c009d46101ba764c358630c24d8b93f6eb..e44d46e796af43439074889dcc6d92847904883c 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -923,6 +923,9 @@ ServiceRegistry* RenderProcessHostImpl::GetServiceRegistry() {
void RenderProcessHostImpl::AddRoute(
int32 routing_id,
IPC::Listener* listener) {
+ // We already have DCHECK() in IDMap. This is for chasing
+ // crbug.com/415059 and can be removed after fixing it.
+ CHECK(!listeners_.Lookup(routing_id));
listeners_.AddWithID(listener, routing_id);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698