build/common.gypi - Issue 647483004: Do not use zero or empty android:versionCode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 647483004: Do not use zero or empty android:versionCode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update GN as well. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 132fd7ce33a9f05a45ba714964f916d205ef11b7..34c7a2c131cffa73321c58e04215cc6a72e397b1 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1416,7 +1416,7 @@

# Sets the default version name and code for Android app, by default we

# do a developer build.

'android_app_version_name%': 'Developer Build',

- 'android_app_version_code%': 0,

+ 'android_app_version_code%': 1,

# Contains data about the attached devices for gyp_managed_install.

'build_device_config_path': '<(PRODUCT_DIR)/build_devices.cfg',

« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | no next file with comments »