Issue 647433004: Don't define ARRAYSIZE_UNSAFE except in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 647433004: Don't define ARRAYSIZE_UNSAFE except in Blink. (Closed)

Created:
6 years, 2 months ago by viettrungluu

Modified:
6 years, 2 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Don't define ARRAYSIZE_UNSAFE except in Blink. (We want to remove it, but there are currently some uses in Blink. We can stop it from reappearing in Chromium.) R=thestig@chromium.org BUG=423134 Committed: https://crrev.com/fbe886d379caf66358093909908dad641a4e94ed Cr-Commit-Position: refs/heads/master@{#300184}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	base/macros.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647433004/20001

6 years, 2 months ago (2014-10-17 22:10:50 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 22:53:57 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/fbe886d379caf66358093909908dad641a4e94ed
Cr-Commit-Position: refs/heads/master@{#300184}