Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2274)

Unified Diff: base/macros.h

Issue 647433004: Don't define ARRAYSIZE_UNSAFE except in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: asdf Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/macros.h
diff --git a/base/macros.h b/base/macros.h
index 2e3fc097596d4416f807b9a222b659d8d2e65954..f89d7d11f9737ed6ce890783323daf227e277b6b 100644
--- a/base/macros.h
+++ b/base/macros.h
@@ -69,8 +69,12 @@ char (&ArraySizeHelper(const T (&array)[N]))[N];
// DEPRECATED: Just use |arraysize()|, now that C++11 has removed the
// limitations that forced the use of |ARRAYSIZE_UNSAFE()|.
-// TODO(viettrungluu): Convert all instances and delete. crbug.com/423134
+// TODO(viettrungluu): Convert all instances and delete. (The only uses are now
+// in Blink; the ifdef is to prevent it from reappearing in Chromium.)
+// crbug.com/423134
+#if defined(BLINK_PLATFORM) || defined(BLINK_PLATFORM_IMPLEMENTATION)
#define ARRAYSIZE_UNSAFE(a) arraysize(a)
+#endif
// Use implicit_cast as a safe version of static_cast or const_cast
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698