Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 647253002: cc: Stop converting update rect from int to float to int. (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Stop converting update rect from int to float to int. Layer::SetNeedsDisplay() would turn the int bounds() into a float RectF just for PictureLayer to turn it back into an int Rect. This is silly. If PictureLayer is just going to use ints, we might as well use ints throughout. So convert update_rect_ from a RectF to a Rect. R=enne BUG=342848 Committed: https://crrev.com/19f0c9e018cc431eb60fa49615192dd091622fef Cr-Commit-Position: refs/heads/master@{#299233}

Patch Set 1 #

Patch Set 2 : displayrectint: . #

Patch Set 3 : displayrectint: . #

Patch Set 4 : displayrectint: ccperftests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -99 lines) Patch
M cc/blink/web_layer_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M cc/debug/debug_rect_history.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/contents_scaling_layer_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M cc/layers/layer.h View 4 chunks +5 lines, -5 lines 0 comments Download
M cc/layers/layer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/layer_impl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_perftest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M cc/layers/picture_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/solid_color_scrollbar_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/tiled_layer_test_common.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/tiled_layer_test_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 20 chunks +21 lines, -21 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 15 chunks +22 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_damage.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
danakj
It seems link blink has an IntRect also until GraphicsLayer, so this is still a ...
6 years, 2 months ago (2014-10-11 00:45:21 UTC) #1
danakj
Added invalidateRect(WebRect) flavours, so blink can use those. Then we can remove the WebFloatRect ones.
6 years, 2 months ago (2014-10-11 00:55:53 UTC) #2
enne (OOO)
lgtm
6 years, 2 months ago (2014-10-11 01:43:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647253002/380001
6 years, 2 months ago (2014-10-11 01:44:37 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:380001)
6 years, 2 months ago (2014-10-11 03:24:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 03:25:34 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/19f0c9e018cc431eb60fa49615192dd091622fef
Cr-Commit-Position: refs/heads/master@{#299233}

Powered by Google App Engine
This is Rietveld 408576698