Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 64723002: VM: Fix identical comparisons with bigints. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: fixed MIPS Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_mips.cc ('k') | tests/language/vm/regress_14903_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_x64.cc
===================================================================
--- runtime/vm/stub_code_x64.cc (revision 30047)
+++ runtime/vm/stub_code_x64.cc (working copy)
@@ -2154,8 +2154,7 @@
}
-// Called from otpimzied code only. Must preserve any registers that are
-// destroyed.
+// Called from optimized code only.
// TOS + 0: return address
// TOS + 1: right argument.
// TOS + 2: left argument.
@@ -2164,14 +2163,10 @@
Assembler* assembler) {
const Register left = RAX;
const Register right = RDX;
- // Preserve left and right.
- __ pushq(left);
- __ pushq(right);
- __ movq(left, Address(RSP, 4 * kWordSize));
- __ movq(right, Address(RSP, 3 * kWordSize));
+
+ __ movq(left, Address(RSP, 2 * kWordSize));
+ __ movq(right, Address(RSP, 1 * kWordSize));
GenerateIdenticalWithNumberCheckStub(assembler, left, right);
- __ popq(right);
- __ popq(left);
__ ret();
}
« no previous file with comments | « runtime/vm/stub_code_mips.cc ('k') | tests/language/vm/regress_14903_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698