emitIAS for store and indirect calls.

emitIAS for store and indirect calls.

We can't do direct calls via the .long sym hack, since that is
normally for an absolute relocation, but calls are expecting
relative relocations (except for reg/mem forms).

Nop-out the InstFake emitIAS methods. Remove the generic dispatcher
that redirects emitIAS() to emit(), since only branches and labels
are left.

BUG=none
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=198b294823bc12bfcf3addb11dc26d4772e2cb8f

[jvoung (off chromium), 2014-10-16 01:51:43]

jvoung@chromium.org changed reviewers:
+ stichnot@chromium.org

[Jim Stichnoth, 2014-10-16 02:48:16]

lgtm

https://codereview.chromium.org/647193003/diff/60001/src/IceInst.h
File src/IceInst.h (left):

https://codereview.chromium.org/647193003/diff/60001/src/IceInst.h#oldcode814
src/IceInst.h:814: void emitIAS(const Cfg *Func) const override { emit(Func); }
Cool!

https://codereview.chromium.org/647193003/diff/60001/src/IceInstX8632.cpp
File src/IceInstX8632.cpp (right):

https://codereview.chromium.org/647193003/diff/60001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:466: assert(CR->getOffset() == 0 && "We only support
calling a function");
llvm_unreachable here too?

[jvoung (off chromium), 2014-10-16 15:22:12]

https://codereview.chromium.org/647193003/diff/60001/src/IceInstX8632.cpp
File src/IceInstX8632.cpp (right):

https://codereview.chromium.org/647193003/diff/60001/src/IceInstX8632.cpp#new...
src/IceInstX8632.cpp:466: assert(CR->getOffset() == 0 && "We only support
calling a function");
On 2014/10/16 02:48:16, stichnot wrote:
> llvm_unreachable here too?

Oh, this one is actually reachable. I let it go through to fill the buffer, and
then I use the "if (NeedsFallback)" part. This is so that I have the right
buffer sizes for emitIAS of branch and labels.

[jvoung (off chromium), 2014-10-16 16:40:08]

Committed patchset #4 (id:60001) manually as
198b294823bc12bfcf3addb11dc26d4772e2cb8f (presubmit successful).