Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 647023003: Fix uninitialized field in DisplayInfo ctor (Closed)

Created:
6 years, 2 months ago by dnicoara
Modified:
6 years, 2 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, Derek Bruening
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized field in DisplayInfo ctor BUG=none TESTS=Ran ash_unittests and ran TouchTransformerControllerTest.* with memcheck NOTRY=true TBR=mukai@chromium.org Committed: https://crrev.com/45f5c20ef75acef17e455a8a55a34e76b0096979 Cr-Commit-Position: refs/heads/master@{#299139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ash/display/display_info.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dnicoara
PTAL https://codereview.chromium.org/635403002 triggered a different path through the unittest code for TouchTransformerControllerTest.* which caused the ...
6 years, 2 months ago (2014-10-10 18:13:20 UTC) #2
Jun Mukai
lgtm
6 years, 2 months ago (2014-10-10 18:17:39 UTC) #4
dnicoara
TBR-ing to green the bot.
6 years, 2 months ago (2014-10-10 18:17:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647023003/1
6 years, 2 months ago (2014-10-10 18:18:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 18:19:18 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 18:19:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45f5c20ef75acef17e455a8a55a34e76b0096979
Cr-Commit-Position: refs/heads/master@{#299139}

Powered by Google App Engine
This is Rietveld 408576698