Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 635403002: Preserve the native mode when parsing external display modes (Closed)

Created:
6 years, 2 months ago by dnicoara
Modified:
6 years, 2 months ago
Reviewers:
Jun Mukai, oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-hotplug-in-mirror-mode
Project:
chromium
Visibility:
Public.

Description

Preserve the native mode when parsing external display modes If the native mode is interlaced it can be replaced by a non-interlaced mode (which will not show as native). BUG=none Committed: https://crrev.com/28b5396f75570b021617b2f2c626a6116d322c7e Cr-Commit-Position: refs/heads/master@{#299114}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -29 lines) Patch
M ash/display/display_change_observer_chromeos.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M ash/display/display_change_observer_chromeos_unittest.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M ash/touch/touch_transformer_controller.cc View 1 2 chunks +8 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
dnicoara
PTAL
6 years, 2 months ago (2014-10-08 17:59:13 UTC) #2
oshima
-> mukai
6 years, 2 months ago (2014-10-08 18:39:30 UTC) #4
dnicoara
Just as a bit more context, the native mode is used to determine the native ...
6 years, 2 months ago (2014-10-08 19:13:38 UTC) #5
Jun Mukai
https://codereview.chromium.org/635403002/diff/20001/ash/display/display_change_observer_chromeos.cc File ash/display/display_change_observer_chromeos.cc (right): https://codereview.chromium.org/635403002/diff/20001/ash/display/display_change_observer_chromeos.cc#newcode149 ash/display/display_change_observer_chromeos.cc:149: display_mode_list.push_back(DisplayMode(native_mode.size(), why not simply pushing |native_mode| here?
6 years, 2 months ago (2014-10-08 19:41:53 UTC) #6
dnicoara
https://codereview.chromium.org/635403002/diff/20001/ash/display/display_change_observer_chromeos.cc File ash/display/display_change_observer_chromeos.cc (right): https://codereview.chromium.org/635403002/diff/20001/ash/display/display_change_observer_chromeos.cc#newcode149 ash/display/display_change_observer_chromeos.cc:149: display_mode_list.push_back(DisplayMode(native_mode.size(), On 2014/10/08 19:41:53, Jun Mukai wrote: > why ...
6 years, 2 months ago (2014-10-08 19:50:43 UTC) #7
Jun Mukai
lgtm
6 years, 2 months ago (2014-10-08 20:03:56 UTC) #8
dnicoara
On 2014/10/08 20:03:56, Jun Mukai wrote: > lgtm Thanks, Oshima-san whould you mind taking a ...
6 years, 2 months ago (2014-10-10 13:56:11 UTC) #9
oshima
lgtm
6 years, 2 months ago (2014-10-10 14:16:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/635403002/40001
6 years, 2 months ago (2014-10-10 14:34:14 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-10 15:01:38 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 15:02:17 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/28b5396f75570b021617b2f2c626a6116d322c7e
Cr-Commit-Position: refs/heads/master@{#299114}

Powered by Google App Engine
This is Rietveld 408576698