chrome/browser/ui/webui/signin/inline_login_handler_impl.cc - Issue 646983008: Implement signin using webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 646983008: Implement signin using webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix crash due to dangling zoom observer Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

index a3d56d65090cab156f1dc4b5e93ec27f8923bb6a..f84ba0feac18674a0e3c5bec88e7f901ed958cc8 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

@@ -378,10 +378,12 @@ void InlineLoginHandlerImpl::CompleteLogin(const base::ListValue* args) {

about_signin_internals->OnAuthenticationResultReceived(

"GAIA Auth Successful");

+ GURL partition_url(switches::IsEnableWebviewBasedSignin() ?

+ "chrome-guest://chrome-signin/?" :

+ chrome::kChromeUIChromeSigninURL);

content::StoragePartition* partition =

content::BrowserContext::GetStoragePartitionForSite(

- contents->GetBrowserContext(),

- GURL(chrome::kChromeUIChromeSigninURL));

+ contents->GetBrowserContext(), partition_url);

SigninClient* signin_client =

ChromeSigninClientFactory::GetForProfile(Profile::FromWebUI(web_ui()));