chrome/browser/resources/inline_login/new_inline_login.html - Issue 646983008: Implement signin using webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/inline_login/new_inline_login.html

Issue 646983008: Implement signin using webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix crash due to dangling zoom observer Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/inline_login/new_inline_login.html

diff --git a/chrome/browser/resources/inline_login/inline_login.html b/chrome/browser/resources/inline_login/new_inline_login.html

similarity index 87%

copy from chrome/browser/resources/inline_login/inline_login.html

copy to chrome/browser/resources/inline_login/new_inline_login.html

index 826780e1ca13e58e6709b12d542ce24cfd542169..68da6c223cd59b9015014c2ed5dd43c52c3f8092 100644

--- a/chrome/browser/resources/inline_login/inline_login.html

+++ b/chrome/browser/resources/inline_login/new_inline_login.html

@@ -8,12 +8,13 @@

+ <script src="chrome://chrome-signin/gaia_auth_host.js"></script>

</head>

- <iframe id="signin-frame" name="signin-frame" frameborder="0" scrolling="no"></iframe>

+ <webview id="signin-frame" name="signin-frame"></webview>

</div>