Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 646873007: [Password Generation] Update popup and confirmation bubble. (Closed)

Created:
6 years, 2 months ago by Garrett Casto
Modified:
6 years, 2 months ago
Reviewers:
dconnelly
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Update popup and confirmation bubble. BUG=318977 Committed: https://crrev.com/3c7729059fa1674dca555dfbaeef4f5e961613ed Cr-Commit-Position: refs/heads/master@{#300729}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Garrett Casto
6 years, 2 months ago (2014-10-21 22:29:14 UTC) #2
dconnelly
one correction, but lgtm afterwards https://codereview.chromium.org/646873007/diff/20001/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/646873007/diff/20001/chrome/app/chromium_strings.grd#newcode470 chrome/app/chromium_strings.grd:470: Chromium will store this ...
6 years, 2 months ago (2014-10-22 09:36:38 UTC) #3
Garrett Casto
https://codereview.chromium.org/646873007/diff/20001/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://codereview.chromium.org/646873007/diff/20001/chrome/app/chromium_strings.grd#newcode470 chrome/app/chromium_strings.grd:470: Chromium will store this in your |Google saved passwords| ...
6 years, 2 months ago (2014-10-22 17:46:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646873007/40001
6 years, 2 months ago (2014-10-22 17:49:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646873007/40001
6 years, 2 months ago (2014-10-22 17:49:58 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-22 19:27:03 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 19:27:33 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3c7729059fa1674dca555dfbaeef4f5e961613ed
Cr-Commit-Position: refs/heads/master@{#300729}

Powered by Google App Engine
This is Rietveld 408576698