Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6513)

Unified Diff: chrome/browser/metrics/variations/variations_seed_store_unittest.cc

Issue 646733002: Added incident report for variations seed signature mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output of git cl format. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_seed_store_unittest.cc
diff --git a/chrome/browser/metrics/variations/variations_seed_store_unittest.cc b/chrome/browser/metrics/variations/variations_seed_store_unittest.cc
index 6f42c807bf3360a0ef55cdc61ad66638707468b4..4c7fedb2af2c44b3181b232e0367f795a53d2607 100644
--- a/chrome/browser/metrics/variations/variations_seed_store_unittest.cc
+++ b/chrome/browser/metrics/variations/variations_seed_store_unittest.cc
@@ -121,6 +121,42 @@ TEST(VariationsSeedStoreTest, LoadSeed) {
EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedDate));
EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedSignature));
+ // The below seed and signature pair were generated using the server's
+ // private key.
+ const std::string base64_seed_data =
+ "CigxZDI5NDY0ZmIzZDc4ZmYxNTU2ZTViNTUxYzY0NDdjYmM3NGU1ZmQwEr0BCh9VTUEtVW5p"
+ "Zm9ybWl0eS1UcmlhbC0xMC1QZXJjZW50GICckqUFOAFCB2RlZmF1bHRKCwoHZGVmYXVsdBAB"
+ "SgwKCGdyb3VwXzAxEAFKDAoIZ3JvdXBfMDIQAUoMCghncm91cF8wMxABSgwKCGdyb3VwXzA0"
+ "EAFKDAoIZ3JvdXBfMDUQAUoMCghncm91cF8wNhABSgwKCGdyb3VwXzA3EAFKDAoIZ3JvdXBf"
+ "MDgQAUoMCghncm91cF8wORAB";
+ const std::string base64_seed_signature =
+ "MEQCIDD1IVxjzWYncun+9IGzqYjZvqxxujQEayJULTlbTGA/AiAr0oVmEgVUQZBYq5VLOSvy"
+ "96JkMYgzTkHPwbv7K/CmgA==";
+ const std::string base64_seed_signature_invalid =
+ "AEQCIDD1IVxjzWYncun+9IGzqYjZvqxxujQEayJULTlbTGA/AiAr0oVmEgVUQZBYq5VLOSvy"
+ "96JkMYgzTkHPwbv7K/CmgA==";
+
+ // Set seed and valid signature in prefs.
+ prefs.SetString(prefs::kVariationsSeed, base64_seed_data);
+ prefs.SetString(prefs::kVariationsSeedSignature, base64_seed_signature);
+
+ // We need a real VariationsSeedStore to test invalid signatures.
+ VariationsSeedStore seed_store_reel(&prefs);
+ seed_store_reel.LoadSeed(&loaded_seed);
+ // Valid signature, so we should get an empty string.
+ EXPECT_EQ(seed_store_reel.GetBadSignature(), "");
+
+ prefs.SetString(prefs::kVariationsSeedSignature,
+ base64_seed_signature_invalid);
+ seed_store_reel.LoadSeed(&loaded_seed);
+ // Invalid signature, so we should get the signature itself.
+ EXPECT_EQ(seed_store_reel.GetBadSignature(), base64_seed_signature_invalid);
+
+ prefs.SetString(prefs::kVariationsSeedSignature, std::string());
+ seed_store_reel.LoadSeed(&loaded_seed);
+ // Empty signature, so we should get an empty string.
+ EXPECT_EQ(seed_store_reel.GetBadSignature(), "");
+
// Check that having no seed in prefs results in a return value of false.
prefs.ClearPref(prefs::kVariationsSeed);
EXPECT_FALSE(seed_store.LoadSeed(&loaded_seed));

Powered by Google App Engine
This is Rietveld 408576698