Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: chrome/browser/metrics/variations/variations_seed_store_unittest.cc

Issue 646733002: Added incident report for variations seed signature mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Output of git cl format. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/variations/variations_seed_store.h" 5 #include "chrome/browser/metrics/variations/variations_seed_store.h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/prefs/testing_pref_service.h" 8 #include "base/prefs/testing_pref_service.h"
9 #include "base/sha1.h" 9 #include "base/sha1.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 // Check that loading a bad seed returns false and clears the pref. 115 // Check that loading a bad seed returns false and clears the pref.
116 prefs.ClearPref(prefs::kVariationsSeed); 116 prefs.ClearPref(prefs::kVariationsSeed);
117 prefs.SetString(prefs::kVariationsSeed, "this should fail"); 117 prefs.SetString(prefs::kVariationsSeed, "this should fail");
118 EXPECT_FALSE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed)); 118 EXPECT_FALSE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed));
119 EXPECT_FALSE(seed_store.LoadSeed(&loaded_seed)); 119 EXPECT_FALSE(seed_store.LoadSeed(&loaded_seed));
120 EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed)); 120 EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed));
121 EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedDate)); 121 EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedDate));
122 EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedSignature)); 122 EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedSignature));
123 123
124 // The below seed and signature pair were generated using the server's
125 // private key.
126 const std::string base64_seed_data =
127 "CigxZDI5NDY0ZmIzZDc4ZmYxNTU2ZTViNTUxYzY0NDdjYmM3NGU1ZmQwEr0BCh9VTUEtVW5p"
128 "Zm9ybWl0eS1UcmlhbC0xMC1QZXJjZW50GICckqUFOAFCB2RlZmF1bHRKCwoHZGVmYXVsdBAB"
129 "SgwKCGdyb3VwXzAxEAFKDAoIZ3JvdXBfMDIQAUoMCghncm91cF8wMxABSgwKCGdyb3VwXzA0"
130 "EAFKDAoIZ3JvdXBfMDUQAUoMCghncm91cF8wNhABSgwKCGdyb3VwXzA3EAFKDAoIZ3JvdXBf"
131 "MDgQAUoMCghncm91cF8wORAB";
132 const std::string base64_seed_signature =
133 "MEQCIDD1IVxjzWYncun+9IGzqYjZvqxxujQEayJULTlbTGA/AiAr0oVmEgVUQZBYq5VLOSvy"
134 "96JkMYgzTkHPwbv7K/CmgA==";
135 const std::string base64_seed_signature_invalid =
136 "AEQCIDD1IVxjzWYncun+9IGzqYjZvqxxujQEayJULTlbTGA/AiAr0oVmEgVUQZBYq5VLOSvy"
137 "96JkMYgzTkHPwbv7K/CmgA==";
138
139 // Set seed and valid signature in prefs.
140 prefs.SetString(prefs::kVariationsSeed, base64_seed_data);
141 prefs.SetString(prefs::kVariationsSeedSignature, base64_seed_signature);
142
143 // We need a real VariationsSeedStore to test invalid signatures.
144 VariationsSeedStore seed_store_reel(&prefs);
145 seed_store_reel.LoadSeed(&loaded_seed);
146 // Valid signature, so we should get an empty string.
147 EXPECT_EQ(seed_store_reel.GetBadSignature(), "");
148
149 prefs.SetString(prefs::kVariationsSeedSignature,
150 base64_seed_signature_invalid);
151 seed_store_reel.LoadSeed(&loaded_seed);
152 // Invalid signature, so we should get the signature itself.
153 EXPECT_EQ(seed_store_reel.GetBadSignature(), base64_seed_signature_invalid);
154
155 prefs.SetString(prefs::kVariationsSeedSignature, std::string());
156 seed_store_reel.LoadSeed(&loaded_seed);
157 // Empty signature, so we should get an empty string.
158 EXPECT_EQ(seed_store_reel.GetBadSignature(), "");
159
124 // Check that having no seed in prefs results in a return value of false. 160 // Check that having no seed in prefs results in a return value of false.
125 prefs.ClearPref(prefs::kVariationsSeed); 161 prefs.ClearPref(prefs::kVariationsSeed);
126 EXPECT_FALSE(seed_store.LoadSeed(&loaded_seed)); 162 EXPECT_FALSE(seed_store.LoadSeed(&loaded_seed));
127 } 163 }
128 164
129 TEST(VariationsSeedStoreTest, StoreSeedData) { 165 TEST(VariationsSeedStoreTest, StoreSeedData) {
130 const variations::VariationsSeed seed = CreateTestSeed(); 166 const variations::VariationsSeed seed = CreateTestSeed();
131 const std::string serialized_seed = SerializeSeed(seed); 167 const std::string serialized_seed = SerializeSeed(seed);
132 168
133 TestingPrefServiceSimple prefs; 169 TestingPrefServiceSimple prefs;
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 seed_store.VerifySeedSignature(seed_data, base64_seed_data)); 251 seed_store.VerifySeedSignature(seed_data, base64_seed_data));
216 #endif 252 #endif
217 253
218 // Using a different seed should not match the signature. 254 // Using a different seed should not match the signature.
219 seed_data[0] = 'x'; 255 seed_data[0] = 'x';
220 EXPECT_EQ(VariationsSeedStore::VARIATIONS_SEED_SIGNATURE_INVALID_SEED, 256 EXPECT_EQ(VariationsSeedStore::VARIATIONS_SEED_SIGNATURE_INVALID_SEED,
221 seed_store.VerifySeedSignature(seed_data, base64_seed_signature)); 257 seed_store.VerifySeedSignature(seed_data, base64_seed_signature));
222 } 258 }
223 259
224 } // namespace chrome_variations 260 } // namespace chrome_variations
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698