chrome/browser/metrics/variations/variations_service.h - Issue 646733002: Added incident report for variations seed signature mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/variations_service.h

Issue 646733002: Added incident report for variations seed signature mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Responded to comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/variations/variations_seed_store_unittest.cc ('K') | « chrome/browser/metrics/variations/variations_seed_store_unittest.cc ('k') | chrome/browser/metrics/variations/variations_service.cc » ('j') | chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/variations/variations_service.h

diff --git a/chrome/browser/metrics/variations/variations_service.h b/chrome/browser/metrics/variations/variations_service.h

index 108d621dbde88993ef1fd273fd7d5a3b7d5c0ce5..fa8cf142abddb5d256705ea7d6528e0eb11dcdf1 100644

--- a/chrome/browser/metrics/variations/variations_service.h

+++ b/chrome/browser/metrics/variations/variations_service.h

@@ -133,6 +133,10 @@ class VariationsService

policy_pref_service_ = service;

}

+ // Returns the invalid variations seed signature in base64. Returns an empty

+ // string if the signature was not invalid.

Alexei Svitkine (slow) 2014/10/15 14:53:07 Nit: "was not invalid" -> "was valid"

Georges Khalil 2014/10/15 16:53:19 Changed to the same description as in variations_s

+ std::string GetInvalidVariationsSeedSignature() const;

protected:

// Starts the fetching process once, where |OnURLFetchComplete| is called with

// the response.