Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/browser/metrics/variations/variations_service.h

Issue 646733002: Added incident report for variations seed signature mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Responded to comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_VARIATIONS_VARIATIONS_SERVICE_H_ 5 #ifndef CHROME_BROWSER_METRICS_VARIATIONS_VARIATIONS_SERVICE_H_
6 #define CHROME_BROWSER_METRICS_VARIATIONS_VARIATIONS_SERVICE_H_ 6 #define CHROME_BROWSER_METRICS_VARIATIONS_VARIATIONS_SERVICE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 PrefService* local_state, 126 PrefService* local_state,
127 metrics::MetricsStateManager* state_manager); 127 metrics::MetricsStateManager* state_manager);
128 128
129 // Set the PrefService responsible for getting policy-related preferences, 129 // Set the PrefService responsible for getting policy-related preferences,
130 // such as the restrict parameter. 130 // such as the restrict parameter.
131 void set_policy_pref_service(PrefService* service) { 131 void set_policy_pref_service(PrefService* service) {
132 DCHECK(service); 132 DCHECK(service);
133 policy_pref_service_ = service; 133 policy_pref_service_ = service;
134 } 134 }
135 135
136 // Returns the invalid variations seed signature in base64. Returns an empty
137 // string if the signature was not invalid.
Alexei Svitkine (slow) 2014/10/15 14:53:07 Nit: "was not invalid" -> "was valid"
Georges Khalil 2014/10/15 16:53:19 Changed to the same description as in variations_s
138 std::string GetInvalidVariationsSeedSignature() const;
139
136 protected: 140 protected:
137 // Starts the fetching process once, where |OnURLFetchComplete| is called with 141 // Starts the fetching process once, where |OnURLFetchComplete| is called with
138 // the response. 142 // the response.
139 virtual void DoActualFetch(); 143 virtual void DoActualFetch();
140 144
141 // Stores the seed to prefs. Set as virtual and protected so that it can be 145 // Stores the seed to prefs. Set as virtual and protected so that it can be
142 // overridden by tests. 146 // overridden by tests.
143 virtual void StoreSeed(const std::string& seed_data, 147 virtual void StoreSeed(const std::string& seed_data,
144 const std::string& seed_signature, 148 const std::string& seed_signature,
145 const base::Time& date_fetched); 149 const base::Time& date_fetched);
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 #endif 234 #endif
231 235
232 base::WeakPtrFactory<VariationsService> weak_ptr_factory_; 236 base::WeakPtrFactory<VariationsService> weak_ptr_factory_;
233 237
234 DISALLOW_COPY_AND_ASSIGN(VariationsService); 238 DISALLOW_COPY_AND_ASSIGN(VariationsService);
235 }; 239 };
236 240
237 } // namespace chrome_variations 241 } // namespace chrome_variations
238 242
239 #endif // CHROME_BROWSER_METRICS_VARIATIONS_VARIATIONS_SERVICE_H_ 243 #endif // CHROME_BROWSER_METRICS_VARIATIONS_VARIATIONS_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698