Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4551)

Unified Diff: chrome/browser/metrics/variations/variations_seed_store.h

Issue 646733002: Added incident report for variations seed signature mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Responded to comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_seed_store.h
diff --git a/chrome/browser/metrics/variations/variations_seed_store.h b/chrome/browser/metrics/variations/variations_seed_store.h
index c81b15e3e0967def607055df822dd13cd7ed7371..cd13c685522335c3aea627f2e53bb65cba5ada34 100644
--- a/chrome/browser/metrics/variations/variations_seed_store.h
+++ b/chrome/browser/metrics/variations/variations_seed_store.h
@@ -55,6 +55,10 @@ class VariationsSeedStore {
// Registers Local State prefs used by this class.
static void RegisterPrefs(PrefRegistrySimple* registry);
+ // Returns the invalid signature in base64 format, or an empty string if the
+ // signature was not invalid.
grt (UTC plus 2) 2014/10/15 15:08:07 shouldn't this be: "..., or an empty string if the
Alexei Svitkine (slow) 2014/10/15 15:16:30 Yeah, that sounds even better!
Georges Khalil 2014/10/15 16:53:19 Done.
+ std::string GetInvalidSignature() const;
+
protected:
// Note: UMA histogram enum - don't re-order or remove entries.
enum VerifySignatureResult {
@@ -88,6 +92,9 @@ class VariationsSeedStore {
// Cached serial number from the most recently fetched variations seed.
std::string variations_serial_number_;
+ // Keeps track of an invalid signature.
+ std::string invalid_base64_signature_;
+
DISALLOW_COPY_AND_ASSIGN(VariationsSeedStore);
};

Powered by Google App Engine
This is Rietveld 408576698