Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: chrome/browser/metrics/variations/variations_seed_store.cc

Issue 646733002: Added incident report for variations seed signature mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Responded to comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_seed_store.cc
diff --git a/chrome/browser/metrics/variations/variations_seed_store.cc b/chrome/browser/metrics/variations/variations_seed_store.cc
index be775309989c3c1b3aef14a3ec04b1df0458414e..edf7bd798e059ce52e9eeec72923ab2a0dc08a87 100644
--- a/chrome/browser/metrics/variations/variations_seed_store.cc
+++ b/chrome/browser/metrics/variations/variations_seed_store.cc
@@ -120,6 +120,7 @@ VariationsSeedStore::~VariationsSeedStore() {
}
bool VariationsSeedStore::LoadSeed(variations::VariationsSeed* seed) {
+ invalid_base64_signature_.clear();
const std::string base64_seed_data =
local_state_->GetString(prefs::kVariationsSeed);
if (base64_seed_data.empty()) {
@@ -150,6 +151,8 @@ bool VariationsSeedStore::LoadSeed(variations::VariationsSeed* seed) {
<< "with result: " << result << ". Clearing the pref.";
ClearPrefs();
RecordVariationSeedEmptyHistogram(VARIATIONS_SEED_INVALID_SIGNATURE);
+ // Record the invalid signature.
+ invalid_base64_signature_ = base64_seed_signature;
return false;
}
}
@@ -272,4 +275,8 @@ VariationsSeedStore::VerifySeedSignature(
return VARIATIONS_SEED_SIGNATURE_INVALID_SEED;
}
+std::string VariationsSeedStore::GetInvalidSignature() const {
+ return invalid_base64_signature_;
+}
+
} // namespace chrome_variations

Powered by Google App Engine
This is Rietveld 408576698