Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 646693003: Removing the CVC parameter from ShowRepostFormWarningDialog Callback. (Closed)

Created:
6 years, 2 months ago by AKVT
Modified:
6 years, 2 months ago
Reviewers:
Ted C, Yaron, boliu
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing the CVC parameter from ShowRepostFormWarningDialog Callback. With this we can reduce the dependency of CVC on AW module. Hence removing this unwanted parameter. BUG=398263 Committed: https://crrev.com/b47e8a0b098e1a9d9b4ce15e8de78cc35af4c87f Cr-Commit-Position: refs/heads/master@{#299147}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed the review comments. #

Total comments: 2

Patch Set 3 : Fixed review comments. #

Messages

Total messages: 14 (3 generated)
AKVT
@boliu & Yaron PTAL
6 years, 2 months ago (2014-10-09 18:36:26 UTC) #2
boliu
https://codereview.chromium.org/646693003/diff/1/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java File android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java (left): https://codereview.chromium.org/646693003/diff/1/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java#oldcode150 android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java:150: if (contentViewCore.getWebContents() == null) return; Still need this check!
6 years, 2 months ago (2014-10-09 18:38:47 UTC) #3
AKVT
PTAL https://codereview.chromium.org/646693003/diff/1/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java File android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java (left): https://codereview.chromium.org/646693003/diff/1/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java#oldcode150 android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java:150: if (contentViewCore.getWebContents() == null) return; On 2014/10/09 18:38:47, ...
6 years, 2 months ago (2014-10-09 18:51:51 UTC) #4
boliu
android_webview lgtm https://codereview.chromium.org/646693003/diff/100001/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java File android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java (right): https://codereview.chromium.org/646693003/diff/100001/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java#newcode151 android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java:151: if (mAwContents.getContentViewCore() == null) return; err, make ...
6 years, 2 months ago (2014-10-09 18:54:13 UTC) #5
AKVT
@Boliu Thanks. @Yaron PTAL https://codereview.chromium.org/646693003/diff/100001/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java File android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java (right): https://codereview.chromium.org/646693003/diff/100001/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java#newcode151 android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java:151: if (mAwContents.getContentViewCore() == null) return; ...
6 years, 2 months ago (2014-10-09 18:58:22 UTC) #7
AKVT
@Ted & Yaron PTAL, I will land this prior to https://codereview.chromium.org/572013002/
6 years, 2 months ago (2014-10-10 17:36:18 UTC) #8
Ted C
lgtm
6 years, 2 months ago (2014-10-10 17:43:25 UTC) #9
Yaron
lgtm
6 years, 2 months ago (2014-10-10 17:45:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646693003/140001
6 years, 2 months ago (2014-10-10 17:46:14 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:140001)
6 years, 2 months ago (2014-10-10 18:34:59 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 18:35:41 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b47e8a0b098e1a9d9b4ce15e8de78cc35af4c87f
Cr-Commit-Position: refs/heads/master@{#299147}

Powered by Google App Engine
This is Rietveld 408576698