Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2177)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

Issue 646693003: Removing the CVC parameter from ShowRepostFormWarningDialog Callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
index 1746eb0fd520549faf3118a9b0bd330924caf1be..2d8b6336810dbbc3ef19d7f8777296bed3ee96d0 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
@@ -20,7 +20,6 @@ import android.webkit.ValueCallback;
import org.chromium.base.ContentUriUtils;
import org.chromium.base.ThreadUtils;
import org.chromium.content.browser.ContentVideoView;
-import org.chromium.content.browser.ContentViewCore;
/**
* Adapts the AwWebContentsDelegate interface to the AwContentsClient interface.
@@ -30,12 +29,14 @@ import org.chromium.content.browser.ContentViewCore;
class AwWebContentsDelegateAdapter extends AwWebContentsDelegate {
private static final String TAG = "AwWebContentsDelegateAdapter";
+ final AwContents mAwContents;
final AwContentsClient mContentsClient;
View mContainerView;
final Context mContext;
- public AwWebContentsDelegateAdapter(AwContentsClient contentsClient,
+ public AwWebContentsDelegateAdapter(AwContents awContents, AwContentsClient contentsClient,
View containerView, Context context) {
+ mAwContents = awContents;
mContentsClient = contentsClient;
setContainerView(containerView);
mContext = context;
@@ -135,7 +136,7 @@ class AwWebContentsDelegateAdapter extends AwWebContentsDelegate {
}
@Override
- public void showRepostFormWarningDialog(final ContentViewCore contentViewCore) {
+ public void showRepostFormWarningDialog() {
// TODO(mkosiba) We should be using something akin to the JsResultReceiver as the
// callback parameter (instead of ContentViewCore) and implement a way of converting
// that to a pair of messages.
@@ -147,17 +148,15 @@ class AwWebContentsDelegateAdapter extends AwWebContentsDelegate {
final Handler handler = new Handler(ThreadUtils.getUiThreadLooper()) {
@Override
public void handleMessage(Message msg) {
- if (contentViewCore.getWebContents() == null) return;
+ if (mAwContents.getNavigationController() == null) return;
switch(msg.what) {
case msgContinuePendingReload: {
- contentViewCore.getWebContents().getNavigationController()
- .continuePendingReload();
+ mAwContents.getNavigationController().continuePendingReload();
break;
}
case msgCancelPendingReload: {
- contentViewCore.getWebContents().getNavigationController()
- .cancelPendingReload();
+ mAwContents.getNavigationController().cancelPendingReload();
break;
}
default:

Powered by Google App Engine
This is Rietveld 408576698