Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: third_party/android_platform/README.chromium

Issue 646683002: Make it easier to debug failed symbolization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-crazy-linker
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/android_platform/development/scripts/stack » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/android_platform/README.chromium
diff --git a/third_party/android_platform/README.chromium b/third_party/android_platform/README.chromium
index 54d41774e3eca7ca956805dc45b67dfca98deb32..80bfe0325c2ec36eead97780fec4b4acb4d773ad 100644
--- a/third_party/android_platform/README.chromium
+++ b/third_party/android_platform/README.chromium
@@ -14,9 +14,5 @@ and a jar containing the AOSP framework to build the Android WebView
glue layer against.
Local Modifications:
-Only picked the few scripts needed by chrome.
-Updated output directories to use environment variable.
-When calling addr2line, check the symbol is a file (and not a directory).
-Added support for parsing LOG(FATAL) and DCHECK errors and their
- stack traces, as emitted by src/base/debug/stack_trace_android.cc
-Added support for finding symbols when library is loaded directly from the APK.
+The scripts for symbolizing stacks (in development/scripts) are heavily
+modified to better suit Chrome development.
rmcilroy 2014/10/09 18:27:52 I'm fine with doing this, but the cl upload check
cjhopman 2014/10/09 18:41:02 I mostly did this because the list of local modifi
« no previous file with comments | « no previous file | third_party/android_platform/development/scripts/stack » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698