third_party/android_platform/README.chromium - Issue 646683002: Make it easier to debug failed symbolization

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/android_platform/README.chromium

Issue 646683002: Make it easier to debug failed symbolization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-crazy-linker

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: Android Platform engineering tools	1 Name: Android Platform engineering tools

2 Short Name: android platform development	2 Short Name: android platform development

3 URL: https://android.googlesource.com/platform/development	3 URL: https://android.googlesource.com/platform/development

4 Version: 0	4 Version: 0

5 Date: 2014/05/02	5 Date: 2014/05/02

6 Revision: 1b10ec4	6 Revision: 1b10ec4

7 License: Apache 2.0	7 License: Apache 2.0

8 License File: NOT_SHIPPED	8 License File: NOT_SHIPPED

9 Security Critical: no	9 Security Critical: no

10	10

11 Description:	11 Description:

12 Android Platform engineering tools, specifically stack symbolization scripts	12 Android Platform engineering tools, specifically stack symbolization scripts

13 and a jar containing the AOSP framework to build the Android WebView	13 and a jar containing the AOSP framework to build the Android WebView

14 glue layer against.	14 glue layer against.

15	15

16 Local Modifications:	16 Local Modifications:

17 Only picked the few scripts needed by chrome.	17 The scripts for symbolizing stacks (in development/scripts) are heavily

18 Updated output directories to use environment variable.	18 modified to better suit Chrome development.
	rmcilroy 2014/10/09 18:27:52 I'm fine with doing this, but the cl upload check I'm fine with doing this, but the cl upload check will fail unless you modify this file anyway, so unless we can change that I would rather each CL just added a line here to avoid the next cl having to needlessly modify this file some other way. cjhopman 2014/10/09 18:41:02 I mostly did this because the list of local modifi Show quoted text On 2014/10/09 18:27:52, rmcilroy wrote: > I'm fine with doing this, but the cl upload check will fail unless you modify > this file anyway, so unless we can change that I would rather each CL just added > a line here to avoid the next cl having to needlessly modify this file some > other way. I mostly did this because the list of local modifications wasn't actually accurate and I expect that even if it is updated to be accurate it wouldn't stay that way for long. That being said, I have kept the list and just added a message that makes it clear that we may have local modifications that aren't listed here (and added some missing modifications).
19 When calling addr2line, check the symbol is a file (and not a directory).

20 Added support for parsing LOG(FATAL) and DCHECK errors and their

21 stack traces, as emitted by src/base/debug/stack_trace_android.cc

22 Added support for finding symbols when library is loaded directly from the APK.

OLD	NEW

« no previous file with comments | « no previous file | third_party/android_platform/development/scripts/stack » ('j') | no next file with comments »