Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 646683002: Make it easier to debug failed symbolization (Closed)

Created:
6 years, 2 months ago by cjhopman
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-crazy-linker
Project:
chromium
Visibility:
Public.

Description

Make it easier to debug failed symbolization This just adds a --verbose argument and some debug logging sprinkled in useful places. Adds '.' as a candidate directory for libraries (gn puts shared libraries at the root build directory). Committed: https://crrev.com/17ffc51dfc9bd6dfe0d38ce8f6f8313544ea25af Cr-Commit-Position: refs/heads/master@{#298952}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Add some missing modifications to the list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M third_party/android_platform/README.chromium View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/android_platform/development/scripts/stack View 5 chunks +10 lines, -3 lines 0 comments Download
M third_party/android_platform/development/scripts/stack_core.py View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 4 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
cjhopman
rmcilroy: *
6 years, 2 months ago (2014-10-09 18:16:23 UTC) #2
rmcilroy
Lgtm, thanks. https://codereview.chromium.org/646683002/diff/50001/third_party/android_platform/README.chromium File third_party/android_platform/README.chromium (right): https://codereview.chromium.org/646683002/diff/50001/third_party/android_platform/README.chromium#newcode18 third_party/android_platform/README.chromium:18: modified to better suit Chrome development. I'm ...
6 years, 2 months ago (2014-10-09 18:27:53 UTC) #3
cjhopman
https://codereview.chromium.org/646683002/diff/50001/third_party/android_platform/README.chromium File third_party/android_platform/README.chromium (right): https://codereview.chromium.org/646683002/diff/50001/third_party/android_platform/README.chromium#newcode18 third_party/android_platform/README.chromium:18: modified to better suit Chrome development. On 2014/10/09 18:27:52, ...
6 years, 2 months ago (2014-10-09 18:41:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646683002/130001
6 years, 2 months ago (2014-10-09 18:42:32 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:130001)
6 years, 2 months ago (2014-10-09 19:07:18 UTC) #7
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/17ffc51dfc9bd6dfe0d38ce8f6f8313544ea25af Cr-Commit-Position: refs/heads/master@{#298952}
6 years, 2 months ago (2014-10-09 19:07:55 UTC) #8
maniscalco
6 years, 2 months ago (2014-10-09 22:51:36 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:130001) has been created in
https://codereview.chromium.org/642843003/ by maniscalco@chromium.org.

The reason for reverting is: "Android Tests" bot is failing in "run stack tool
with logcat dump" step.

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests

Suspecting this patch.  Reverting.


@@@BUILD_STEP Run stack tool with logcat dump@@@
>
/b/build/slave/Android_Tests/build/src/third_party/android_platform/development/scripts/stack
--more-info /b/build/slave/Android_Tests/build/src/out/Release/full_log.txt
/b/build/slave/Android_Tests/build/src/third_party/android_platform/development/scripts/../../../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/arm-linux-androideabi-addr2line:
/b/build/slave/Android_Tests/build/src/third_party/android_platform/development/scripts/../../../../out/Release/icudtl.dat:
File format not recognized


See bug https://code.google.com/p/chromium/issues/detail?id=422090.

Powered by Google App Engine
This is Rietveld 408576698