media/formats/mp2t/es_parser_adts_unittest.cc - Issue 646673002: Skip audio frames with unknown timestamp in MPEG2TS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp2t/es_parser_adts_unittest.cc

Issue 646673002: Skip audio frames with unknown timestamp in MPEG2TS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed also mpeg1 parser and updated unit tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mp2t/es_parser_adts_unittest.cc

diff --git a/media/formats/mp2t/es_parser_adts_unittest.cc b/media/formats/mp2t/es_parser_adts_unittest.cc

index a65635a53a6356b56f1d3b1654522988fcc12f2e..d1952f30a8850cf9638a5ec9c5d32f032ee4fc82 100644

--- a/media/formats/mp2t/es_parser_adts_unittest.cc

+++ b/media/formats/mp2t/es_parser_adts_unittest.cc

@@ -47,7 +47,11 @@ bool EsParserAdtsTest::Process(

TEST_F(EsParserAdtsTest, NoInitialPts) {

LoadStream("bear.adts");

std::vector<Packet> pes_packets = GenerateFixedSizePesPacket(512);

- EXPECT_FALSE(Process(pes_packets, false));

+ // Process should succeed even without timing info, we should just skip the

+ // audio frames without timing info, but still should be able to parse and

+ // play the stream after that.

+ EXPECT_TRUE(Process(pes_packets, false));

+ EXPECT_EQ(1u, config_count_);

EXPECT_EQ(0u, buffer_count_);

}